perf(storage): resolve connection secrets lazily and handle Keychain errors gracefully (#916) - #947
Merged
ZhuchkaTriplesix merged 1 commit intoSep 25, 2026
Conversation
…errors gracefully (Closes #916)
ZhuchkaTriplesix
deleted the
issue/916-lazy-secrets-keychain-error-handling
branch
September 28, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocalDb.getConnections()lazy by default (hydrateSecrets: false), as the sidebar connection tree only requires basic metadata.ConnectionSecretsStore.readForConnectionandLocalDb._hydrateConnectionintry/catchto gracefully swallow platform Keychain / D-Bus errors without failing connection tree rendering.LocalDb.hydrateConnectionandgetConnectionById) while keeping driver on-connect secret resolution intact.failNextReadto verify graceful degradation and lazy secret resolution.Linked issue
Closes #916
Checklist
flutter analyzepasses locallydev