fix(security): sanitize quoted passwords and tokens containing spaces in SandboxSanitizer (#918) - #949
Merged
Conversation
… in SandboxSanitizer (Closes #918)
github-actions
Bot
added
bug
ZhuchkaTriplesix
deleted the
issue/918-sandbox-sanitizer-quoted-secrets
branch
September 28, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #918
Summary of Changes
_passwordAssignmentregex inSandboxSanitizerto distinguish quoted strings (both single and double quotes, supporting spaces and escaped quotes) from unquoted tokens, and handle optional quotes around assignment keys.sanitize()mapping logic to preserve quotes around redacted tokens when input values are quoted.sandbox_sanitization_pipe_test.dartcovering multi-word single- and double-quoted secrets, escaped quotes, and unquoted values.