fix(grid): purge deleted rows and sanitize kNullSentinel on Save in staging buffer (#884) - #960
Merged
ZhuchkaTriplesix merged 1 commit intoSep 25, 2026
Conversation
…n staging buffer (Closes #884) After a successful Save the new baseline was built from effectiveRows, which kept rows marked for deletion and leaked the raw NULL sentinel into cells. Add DataGridStagingBuffer.committedRows (deleted baseline rows dropped, staged NULLs mapped to 'NULL') and use it as the post-save baseline in the Postgres/MySQL/SQLite table views and SQL workspaces. effectiveRows keeps row indices aligned with the grid for struck-through rendering but now also maps the sentinel to 'NULL'.
github-actions
Bot
added
bug
ZhuchkaTriplesix
deleted the
issue/884-staging-purge-deleted-null-sentinel
branch
September 28, 2026 08:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание изменений
DataGridStagingBuffer.committedRows: baseline после сохранения без удалённых строк и с'NULL'вместоkNullSentinel.effectiveRowsнаcommittedRows.effectiveRowsнамеренно не исключает удалённые строки: индексы должны совпадать с гридом, где такие строки рисуются зачёркнутыми. Зато теперь он тоже маппит sentinel в'NULL'.data_grid_staging_buffer_test,table_view_staging_test.Связанные Issue
Closes #884
Тесты локально не запускались (есть CI),
dart analyzeчистый.