Skip to content

fix(packaging): handle Windows binary extension (.exe) in manifest.json and packaging script #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Sep 27, 2026
Merged

fix(packaging): handle Windows binary extension (.exe) in manifest.json and packaging script #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions scripts/package_qext.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,29 @@ mkdir -p "${STAGING_DIR}/bin" "${STAGING_DIR}/assets"
cp manifest.json "${STAGING_DIR}/"
cp -r assets/* "${STAGING_DIR}/assets/"

# For Windows targets, adjust manifest.json main entry point to include .exe extension
if [[ "$TARGET" == *"windows"* ]] || [[ "$DEST_BIN_NAME" == *".exe" ]]; then
python3 -c "
import json, sys
manifest_path = sys.argv[1]
dest_bin = sys.argv[2]
with open(manifest_path, 'r', encoding='utf-8') as f:
manifest = json.load(f)
manifest['main'] = f'bin/{dest_bin}'
with open(manifest_path, 'w', encoding='utf-8') as f:
json.dump(manifest, f, indent=2, ensure_ascii=False)
" "${STAGING_DIR}/manifest.json" "${DEST_BIN_NAME}"
fi

# 2. Copy binary into bin/ under both the manifest main entry and original name
cp "${BIN_PATH}" "${STAGING_DIR}/bin/${DEST_BIN_NAME}"
if [ "${DEST_BIN_NAME}" != "${BIN_NAME}" ] && [ ! -f "${STAGING_DIR}/bin/${BIN_NAME}" ]; then
cp "${BIN_PATH}" "${STAGING_DIR}/bin/${BIN_NAME}"
fi
# On Windows packages, also provide the extensionless binary name for backward compatibility
if [[ "$DEST_BIN_NAME" == *".exe" ]] && [ ! -f "${STAGING_DIR}/bin/clickhouse_rpc_server" ]; then
cp "${BIN_PATH}" "${STAGING_DIR}/bin/clickhouse_rpc_server" 2>/dev/null || true
fi
chmod +x "${STAGING_DIR}/bin/${DEST_BIN_NAME}"
if [ -f "${STAGING_DIR}/bin/${BIN_NAME}" ]; then
chmod +x "${STAGING_DIR}/bin/${BIN_NAME}"
Expand Down
Loading