Skip to content

fix(security): prevent SQL injection in schema introspection and context actions #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Sep 27, 2026
Merged

fix(security): prevent SQL injection in schema introspection and context actions #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/rpc/handlers/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ pub async fn handle_expand_tree_node(params: Option<Value>) -> Result<Value, Dri
let filter_view = group_type == "views";
let sql = format!(
"SELECT t.name AS name, t.engine AS engine, t.total_rows AS total_rows, formatReadableSize(t.total_bytes) AS size_readable, t.comment AS comment, multiIf(t.engine LIKE '%View%', 'view', t.engine LIKE '%Dictionary%', 'dictionary', 'table') AS object_type FROM system.tables t WHERE database = '{}' ORDER BY name FORMAT JSONCompactEachRowWithNamesAndTypes",
db_name
crate::utils::sql_escape::escape_sql_string_literal(db_name)
);

let text = if is_mock {
Expand All @@ -149,7 +149,7 @@ pub async fn handle_expand_tree_node(params: Option<Value>) -> Result<Value, Dri
} else if group_type == "dictionaries" {
let sql = format!(
"SELECT name, status, type, element_count, load_factor, formatReadableSize(bytes_allocated) AS size FROM system.dictionaries WHERE database = '{}' FORMAT JSONCompactEachRowWithNamesAndTypes",
db_name
crate::utils::sql_escape::escape_sql_string_literal(db_name)
);

let text = if is_mock {
Expand All @@ -172,7 +172,8 @@ pub async fn handle_expand_tree_node(params: Option<Value>) -> Result<Value, Dri
let table_name = parts[2];
let sql = format!(
"SELECT name, type, comment FROM system.columns WHERE database = '{}' AND table = '{}' ORDER BY position FORMAT JSONCompactEachRowWithNamesAndTypes",
db_name, table_name
crate::utils::sql_escape::escape_sql_string_literal(db_name),
crate::utils::sql_escape::escape_sql_string_literal(table_name)
);

let text = if is_mock {
Expand All @@ -195,7 +196,8 @@ pub async fn handle_expand_tree_node(params: Option<Value>) -> Result<Value, Dri
let table_name = parts[2];
let sql = format!(
"SELECT partition, sum(rows) AS total_rows, formatReadableSize(sum(data_compressed_bytes)) AS compressed_size, count() AS parts_count FROM system.parts WHERE database = '{}' AND table = '{}' AND active = 1 GROUP BY partition ORDER BY partition DESC FORMAT JSONCompactEachRowWithNamesAndTypes",
db_name, table_name
crate::utils::sql_escape::escape_sql_string_literal(db_name),
crate::utils::sql_escape::escape_sql_string_literal(table_name)
);

let text = if is_mock {
Expand Down Expand Up @@ -418,8 +420,9 @@ pub async fn handle_get_object_metadata(params: Option<Value>) -> Result<Value,
}

let ddl_sql = format!(
"SHOW CREATE TABLE `{}`.`{}` FORMAT JSONCompactEachRow",
db_name, tbl_name
"SHOW CREATE TABLE {}.{} FORMAT JSONCompactEachRow",
crate::utils::sql_escape::quote_identifier(db_name),
crate::utils::sql_escape::quote_identifier(tbl_name)
);
let mut ddl_str = String::new();
if let Ok(text) = client.post_sql(&ddl_sql, |_| {}).await
Expand All @@ -432,7 +435,8 @@ pub async fn handle_get_object_metadata(params: Option<Value>) -> Result<Value,

let cols_sql = format!(
"SELECT name, type, comment FROM system.columns WHERE database = '{}' AND table = '{}' ORDER BY position FORMAT JSONCompactEachRowWithNamesAndTypes",
db_name, tbl_name
crate::utils::sql_escape::escape_sql_string_literal(db_name),
crate::utils::sql_escape::escape_sql_string_literal(tbl_name)
);
let mut columns = Vec::new();
if let Ok(text) = client.post_sql(&cols_sql, |_| {}).await
Expand Down
Loading
Loading