Repository navigation
fix(schema): implement robust delimiter escaping for nodeId path segments - #67
Merged
Merged
Conversation
…ents nodeId values (e.g. "table.analytics.events") were split naively on '.' in db.expandTreeNode, sdui.contextActions and db.getObjectMetadata. ClickHouse allows literal '.' inside backtick-quoted database/table names and inside partition values, so such an identifier misaligned every downstream segment once split. Add src/utils/node_id.rs with encode_id_segment/decode_id_segment, escaping '.' and '~' within each dynamic segment before it is joined into a nodeId, and split_node_id to reverse it. Wire it into src/sdui/tree.rs (node construction), src/rpc/handlers/schema.rs and src/sdui/actions.rs (node parsing). Closes #56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/utils/node_id.rswithencode_id_segment/decode_id_segment/split_node_id, escaping literal.and~within each dynamic nodeId segment before joiningsrc/sdui/tree.rsnode construction (db, table, view, dictionary, column, partition ids)src/rpc/handlers/schema.rs(db.expandTreeNode,db.getObjectMetadata) andsrc/sdui/actions.rs(sdui.contextActions), replacing naivenodeId.split('.')Closes #56