test(query): add regression coverage for escaped/doubled quote handling in SQL parser - #70
Merged
Conversation
…ng in SQL parser. Closes #59 strip_sql_comments_and_trim and split_sql_statements already handle backslash-escaped quotes (\') and SQL-standard doubled quotes ('') inside string literals correctly — this was fixed as a side effect of the Safe Mode multi-statement bypass fix (#54, commit 751393e), which rewrote the in_string branch of both functions to consume the escape/doubled-quote pair instead of treating the first quote as a closing quote. Add regression tests for both functions plus enforce_safe_mode_precheck covering the exact failure scenarios from #59: a query with an escaped quote followed by `-- ` no longer has its trailing FROM clause eaten by a fake comment, and a doubled-quote literal no longer leaks its content as bare keywords or desynchronizes string tracking for the rest of the query.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strip_sql_comments_and_trimandsplit_sql_statementsinsrc/rpc/handlers/query.rsalready handle backslash-escaped quotes (\') and SQL-standard doubled quotes ('') inside string literals correctly — this was fixed as a side effect of the Safe Mode multi-statement bypass fix (fix(security): prevent Safe Mode precheck bypass on multi-statement SQL queries #54, commit751393e), which rewrote thein_stringbranch of both functions to consume the escape/doubled-quote pair instead of treating the first quote as a closing quote.--, and a doubled-quote literal), for both the low-level parser functions and theenforce_safe_mode_precheckintegration path, to lock in the current correct behavior and document that it's intentional.Closes #59
Test plan
cargo test— 93/93 passing, including the 3 new tests added herecargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warnings