feat: implement secure item drop system with server-side validation - #17
Open
Darrin-Lin wants to merge 1 commit into
Open
feat: implement secure item drop system with server-side validation#17Darrin-Lin wants to merge 1 commit into
Darrin-Lin wants to merge 1 commit into
Conversation
…nd anti-cheat checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new secure system for handling pending item and gold drops for players, along with related API and validation improvements. The changes add a new model to track pending drops, update serializers and endpoints to support secure claims, and enhance validation and testing to prevent exploits.
Secure pending drops system:
PlayerPendingDropmodel to record pending item or gold drops for players, including ownership, item data, gold amount, and timestamps. This model is managed via a new database migration and includes a string representation for easy debugging. [1] [2]API and serializer updates:
PlayerProfileUpdateSerializerto accept a list ofclaimed_drops, enabling clients to securely claim pending drops.PlayerDropViewAPI endpoint and registered it under the/drop/path to handle drop-related operations.Validation and testing improvements: