feat(backend): add pending invoice stats helper (#278) - #353
Draft
s6pa1rta3n-lab wants to merge 1 commit into
Draft
feat(backend): add pending invoice stats helper (#278)#353s6pa1rta3n-lab wants to merge 1 commit into
s6pa1rta3n-lab wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
isPendingInvoice(invoice)inbackend/src/utils/stats-pending-filter.tsto ensure consistent pending invoice classification across dashboard stats and storage aggregators, and wires it intocalculateInvoiceStatsinbackend/src/storage/invoice-stats.ts.Changes
backend/src/utils/stats-pending-filter.ts: ImplementedisPendingInvoice()predicate andPENDING_STATUSconstant.backend/tests/fixtures/stats-pending-filter.fixture.ts: Added fixture cases covering valid pending invoices, non-pending statuses, and malformed inputs.backend/tests/stats-pending-filter.test.ts: Added unit test suite covering constants, valid fixtures, non-pending fixtures, malformed inputs, and array filtering operations.backend/src/storage/invoice-stats.ts: ImportedisPendingInvoiceand replaced inline status check with the shared predicate.Verification
npm test: All backend unit & isolated tests pass cleanly (187 passing tests).npm run typecheck: TypeScript verification passes with 0 errors.Closes #278
Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC