-
Notifications
You must be signed in to change notification settings - Fork 1
Improvements to SEO #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ff25a3d
b1cee89
8bc3628
c639bdd
04c9b7c
6f76e8c
1c098d9
f4120cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
|
|
||
| # clerk configuration (can include secrets) | ||
| /.clerk/ | ||
| .vercel |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,6 @@ | ||||||||||||||||||||||
| import { api } from "@workspace/backend/_generated/api"; | ||||||||||||||||||||||
| import { fetchAction } from "convex/nextjs"; | ||||||||||||||||||||||
| import { createMetadata } from "@workspace/seo/metadata"; | ||||||||||||||||||||||
| import { PaperLayoutClient } from "./client"; | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| type Props = { | ||||||||||||||||||||||
|
|
@@ -36,11 +37,16 @@ export async function generateMetadata({ | |||||||||||||||||||||
| }, | ||||||||||||||||||||||
| ); | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| return { | ||||||||||||||||||||||
| title: `${paper.title} | Paper | Qurious`, | ||||||||||||||||||||||
| }; | ||||||||||||||||||||||
| return createMetadata({ | ||||||||||||||||||||||
| title: `${paper.title} | Paper`, | ||||||||||||||||||||||
| description: | ||||||||||||||||||||||
| paper.tldr?.text || paper.abstract || "View paper details on Qurious", | ||||||||||||||||||||||
| }); | ||||||||||||||||||||||
|
Comment on lines
+40
to
+44
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Double title suffix:
Suggested fix return createMetadata({
- title: `${paper.title} | Paper`,
+ title: paper.title,
description:
paper.tldr?.text || paper.abstract || "View paper details on Qurious",
});📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||
| } catch { | ||||||||||||||||||||||
| return { title: "Paper | Qurious" }; | ||||||||||||||||||||||
| return createMetadata({ | ||||||||||||||||||||||
| title: "Paper", | ||||||||||||||||||||||
| description: "View paper details on Qurious", | ||||||||||||||||||||||
| }); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
|
|
||||||||||||||||||||||
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,11 +1,11 @@ | ||||||||||||||||||||
| import type { Metadata } from "next"; | ||||||||||||||||||||
| import Link from "next/link"; | ||||||||||||||||||||
| import { APP_NAME, LEGAL_CONFIG } from "@workspace/design-system/content"; | ||||||||||||||||||||
| import { createMetadata } from "@workspace/seo/metadata"; | ||||||||||||||||||||
|
|
||||||||||||||||||||
| export const metadata: Metadata = { | ||||||||||||||||||||
| title: `Terms of Service | ${APP_NAME}`, | ||||||||||||||||||||
| export const metadata = createMetadata({ | ||||||||||||||||||||
| title: "Terms of Service", | ||||||||||||||||||||
| description: `Terms of Service for ${APP_NAME} - A research tool for the AI age.`, | ||||||||||||||||||||
| }; | ||||||||||||||||||||
| }); | ||||||||||||||||||||
|
Comment on lines
+5
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Consider making the Terms description more page-specific. The Privacy page description explains what the user will learn ("how we collect, use, and protect your data"), but the Terms description falls back to a generic app tagline ("A research tool for the AI age"). A more specific description like ✏️ Suggested description improvement export const metadata = createMetadata({
title: "Terms of Service",
- description: `Terms of Service for ${APP_NAME} - A research tool for the AI age.`,
+ description: `Terms of Service for ${APP_NAME} - Read the rules and guidelines for using our platform.`,
});📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||
|
|
||||||||||||||||||||
| export default function TermsPage() { | ||||||||||||||||||||
| return ( | ||||||||||||||||||||
|
|
||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,7 +82,9 @@ | |
| "worklets", | ||
| "zod", | ||
| "zotero", | ||
| "samhoque" | ||
| "samhoque", | ||
| "Sahil", | ||
| "sahillll" | ||
|
Comment on lines
+85
to
+87
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Maintain alphabetical ordering of the words list. The existing entries are alphabetically sorted, but 🤖 Prompt for AI Agents |
||
| ], | ||
| "ignorePaths": [ | ||
| "**/*.map", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title will render as
"FolderName | Folder | Qurious"due to double suffixing.As noted in
packages/seo/metadata.ts,createMetadataappends" | Qurious"to the title. Passing\${folder.name} | Folder`here produces a three-segment title. If a two-segment title is intended, pass just the folder name and letcreateMetadata` handle the suffix:Proposed fix
return createMetadata({ - title: `${folder.name} | Folder`, + title: folder.name, description: `View and manage papers and searches in the ${folder.name} folder`, });📝 Committable suggestion
🤖 Prompt for AI Agents