1.3.5 update#58
Merged
smasongarrison merged 77 commits intomainfrom Apr 2, 2025
Merged
Conversation
Rename benchmark.R to data-raw/benchmark.R
Formerly only correctly handled 0 or 2 parents. 2 missing parents needs 1 in S matrix. 1 missing parent needs .75 in S matrix. 0 missing parents needs .5 in S matrix. This is the standard way of handling this in animal breeding.
This method is not yet tested!
forgot docs
adding Povich Algorithm Optimization to Dev branch
fixed more saveable steps, moved generation comonent higher
a couple more tests and utils::write
smasongarrison
force-pushed
the
dev_main
branch
from
c66052b to
bf70997
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the BGmisc package to version 1.3.5 by introducing new features and improving existing functions while also updating the changelog.
- Added new functions (com2links(), extractWikiFamilyTree(), checkPedigreeNetwork()) with corresponding tests.
- Enhanced the documentation in README.md and updated the NEWS.md changelog for version 1.3.5 and related hotfixes.
Reviewed Changes
Copilot reviewed 40 out of 58 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adjusted badge formatting; note potential markdown formatting issue. |
| NEWS.md | Expanded changelog to include version 1.3.5 updates and additional fixes. |
Files not reviewed (18)
- .Rbuildignore: Language not supported
- .lintr: Language not supported
- BGmisc.Rproj: Language not supported
- DESCRIPTION: Language not supported
- NAMESPACE: Language not supported
- R/buildPedigree.R: Language not supported
- R/checkPedigree.R: Language not supported
- R/checkSex.R: Language not supported
- R/convertPedigree.R: Language not supported
- R/documentData.R: Language not supported
- R/plotPedigree.R: Language not supported
- R/readPedigree.R: Language not supported
- R/summarizePedigree.R: Language not supported
- README.Rmd: Language not supported
- data-raw/benchmark.R: Language not supported
- data-raw/df_ASOIAF.R: Language not supported
- data-raw/df_royal92.R: Language not supported
- man/ASOIAF.Rd: Language not supported
Comments suppressed due to low confidence (1)
README.md:17
- The badge label 'Dev Main branch' appears split across two lines, which might cause markdown rendering issues. Consider combining the label into a single line.
[
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.3.5 update