added ASOIAF dataset and network validation checks#59
Merged
smasongarrison merged 6 commits intodev_mainfrom Mar 31, 2025
Merged
added ASOIAF dataset and network validation checks#59smasongarrison merged 6 commits intodev_mainfrom
smasongarrison merged 6 commits intodev_mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the changelog for BGmisc 1.3.5 by adding several new features and updates, including the ASOIAF dataset/pedigree addition and updated function entries with tests.
- Added an entry for the ASOIAF pedigree
- Revised descriptions for com2links(), extractWikiFamilyTree(), plotPedigree(), and checkPedigreeNetwork() to highlight added functionality and tests
Files not reviewed (14)
- NAMESPACE: Language not supported
- R/checkPedigree.R: Language not supported
- R/checkSex.R: Language not supported
- R/documentData.R: Language not supported
- R/makeLinks.R: Language not supported
- R/summarizePedigree.R: Language not supported
- data-raw/df_ASOIAF.R: Language not supported
- man/ASOIAF.Rd: Language not supported
- man/checkPedigreeNetwork.Rd: Language not supported
- man/repairSex.Rd: Language not supported
- man/summarizePedigrees.Rd: Language not supported
- tests/testthat/test-checkPedigreeNetwork.R: Language not supported
- tests/testthat/test-checkSex.R: Language not supported
- vignettes/partial.Rmd: Language not supported
Comments suppressed due to low confidence (1)
NEWS.md:2
- [nitpick] The bullet point mentions 'ASOIAF pedigree' while the PR title and description refer to an 'ASOIF dataset'. Consider aligning the terminology for consistency.
* Added ASOIAF pedigree
2 tasks
smasongarrison
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added asoif dataset