Smarterwithdups#3
Merged
smasongarrison merged 18 commits intomainfrom May 15, 2025
Merged
Conversation
making progross by reconnecting
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR, titled "Smarterwithdups", implements a major overhaul for handling duplicate members in pedigree layouts. Key changes include adjusting visual parameters (e.g. point and label sizes), refactoring duplicate appearance resolution logic with new helper functions, and updating documentation and tests to reflect the revised handling.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vignettes/plots_morecomplexity.xmd | Reduced point size and added a label text size option to fine‑tune plot scales. |
| vignettes/plots.Rmd | Introduced additional complex plotting examples and removed extra blank lines. |
| tests/testthat/test-calcCoordinates.R | Updated test to check against the new nested connection structure. |
| man/ggPedigree.Rd | Adjusted file reference in documentation to match the actual filename. |
| R/processExtras.R | Updated duplicate handling logic with unique numeric IDs and related operations. |
| R/calcConnections.R | Standardized naming conventions for identifiers such as parent hashes. |
| DESCRIPTION | Added required dependencies for string and tibble support. |
| .Rbuildignore | Updated ignore settings to include files ending with .X |
Comments suppressed due to low confidence (3)
tests/testthat/test-calcCoordinates.R:64
- Ensure that the updated test properly validates the new structure of 'conns$connections' after the duplicate handling changes. Confirm that the expected column names match the updated connections output.
expect_true(all(expected_cols %in% names(conns$connections)))
vignettes/plots_morecomplexity.xmd:130
- The new value for 'point_size' is significantly reduced from 3 to .5, and a new 'label_text_size' parameter is introduced. Please verify if these adjustments produce the intended visual outcome for the pedigree plots.
point_size = .5,
man/ggPedigree.Rd:2
- The documentation now references 'R/ggpedigree.R'; please confirm this matches the actual file naming to avoid potential confusion.
% Please edit documentation in R/ggpedigree.R
5ab553b to
f4133dc
Compare
f4133dc to
0d0c7b5
Compare
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR, titled "Smarterwithdups", implements a major overhaul for handling duplicate members in pedigree layouts. Key changes include adjusting visual parameters (e.g. point and label sizes), refactoring duplicate appearance resolution logic with new helper functions, and updating documentation and tests to reflect the revised handling.