style: POSIX character classes in tr (5q6.7)#2
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the package name normalization in the scaffold script to use POSIX character classes in File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
Updates the scaffold script’s case-normalization step to satisfy ShellCheck’s guidance around locale-aware character ranges, restoring a green lint job without changing behavior for ASCII-only project names.
Changes:
- Replace
tr 'A-Z' 'a-z'withtr '[:upper:]' '[:lower:]'when derivingPKGfromNAME.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShellCheck SC2018/SC2019 on scaffold.sh:57 — tr 'A-Z' 'a-z' is flagged because plain ranges don't cover accents/foreign alphabets. Switch to tr '[:upper:]' '[:lower:]'. No behavior change for ASCII names; turns the lint CI job green so PR #1 can merge.
2561789 to
0c5578a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
project-kit-5q6.7.ShellCheck (the
lintCI job) was failing onscripts/scaffold.sh:57:tr 'A-Z' 'a-z'trips SC2019/SC2018 (plain ranges don't cover accented/foreign alphabets). The action exits 1 on any finding, somainwas red and the repo's first PR (#1) inherited it.Fix:
tr '[:upper:]' '[:lower:]'. No behavior change for ASCII project names; turnslintgreen.Pre-existing since
964a15b(the 5q6.2 scaffold feat), discovered while landing the 5q6.3 doc. Kept out of the docs PR to preserve one-intention-per-branch.