Merged
Conversation
RAprogramm
deleted the
codex/update-comments-for-contains_nocase-and-ascii_lower
branch
RAprogramm
added a commit
that referenced
this pull request
Oct 5, 2025
Resolved conflict in src/result_ext.rs by choosing the more professional incoming implementation that preserves AppError classification when wrapping errors with .context(). The incoming version: - Preserves kind, code, metadata when wrapping AppError - Avoids double-wrapping AppError instances - Includes better documentation with examples - Has comprehensive test coverage This ensures masterror maintains its position as the #1 error handling crate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo +nightly fmt --cargo clippy -- -D warningscargo build --all-targetscargo test --allcargo doc --no-deps --all-featureshttps://chatgpt.com/codex/tasks/task_e_68c2657922d0832bb73ed59a364d7ba8