Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ reqwest = { version = "0.12", optional = true, default-features = false }

[dev-dependencies]
serde_json = "1"
tokio = { version = "1", features = ["macros", "rt-multi-thread", "net", "time"], default-features = false }

[lib]
crate-type = ["cdylib", "rlib"]
45 changes: 44 additions & 1 deletion src/convert/reqwest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ use crate::AppError;
impl From<ReqwestError> for AppError {
fn from(err: ReqwestError) -> Self {
if err.is_timeout() {
AppError::timeout("Request timeout")
AppError::timeout(format!("Request timeout: {err}"))
} else if err.is_connect() || err.is_request() {
AppError::network(format!("Network error: {err}"))
} else if err.is_status() {
Expand All @@ -66,3 +66,46 @@ impl From<ReqwestError> for AppError {
}
}
}

#[cfg(all(test, feature = "reqwest", feature = "tokio"))]
mod tests {
use std::time::Duration;

use reqwest::Client;
use tokio::{net::TcpListener, time::sleep};

use super::*;

#[tokio::test]
async fn timeout_message_includes_original_error() {
let listener = TcpListener::bind("127.0.0.1:0")
.await
.expect("bind listener");
let addr = listener.local_addr().expect("listener addr");

let server = tokio::spawn(async move {
let (_socket, _) = listener.accept().await.expect("accept");
sleep(Duration::from_secs(5)).await;
});

let client = Client::builder()
.timeout(Duration::from_millis(50))
.build()
.expect("client");

let err = client
.get(format!("http://{addr}"))
.send()
.await
.expect_err("expected timeout");

assert!(err.is_timeout());

let err_str = err.to_string();
let app_err: AppError = err.into();
let msg = app_err.message.expect("app error message");
assert!(msg.contains(&err_str), "{msg} does not contain {err_str}");

server.abort();
}
}