[GRDM-57860] Add default max quota configuration for institutions not using NII Storage#751
Draft
ndnhat1 wants to merge 7 commits into
Draft
[GRDM-57860] Add default max quota configuration for institutions not using NII Storage#751ndnhat1 wants to merge 7 commits into
ndnhat1 wants to merge 7 commits into
Conversation
…or Institution Storage
+ Fix institution default max quota issues (owner lookup, zero quota, quota retrieval, transaction handling) + Refactor quota handling logic + Update migration (use OneToOneField and remove db_index) + Update default value in "Institutional Storage Quota Control" screen
…logic in Institution Storage
+ Fix user quota update rollback behavior + Align related_name between model and migration + Remove unused user parameter from file_modified + Update UT after change logic
yacchin1205
approved these changes
Jun 19, 2026
yacchin1205
left a comment
yacchin1205
left a comment
There was a problem hiding this comment.
以下の点は、少し注意が必要なように思いましたが、Approveとさせていただきます。ご参考まで。
- InstitutionDefaultMaxQuota を活用するためには、InstitutionDefaultMaxQuotaだけを更新するUIの動線があると良いように思いました。今は、InstitutionDefaultMaxQuotaと、全ユーザーのQuota変更を一律に行うように見えるので、ユーザーに対する個別Quota変更対応があった場合、この操作は不可能になる。(特別対応をしたユーザーの分のQuotaも戻ってしまうため) とすると、この操作はかなり破壊的な操作であって、機関管理者が選択しづらいように思いました。
- エラー処理のうち、 IntegrityErrorの処理においては、warningログ等を記録しておくと運用の助けになるのではないかと感じました。IntegrityErrorは、すでに同一レコードがある場合以外でも、今後発生する可能性があると思うので、ここで例外を記録しておくと、except内の処理も失敗した場合の調査の助けになるように感じました。
… quota management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of these changes is to allow institution administrators to configure a default max quota that will be applied to all users affiliated with their institution. This feature applies to institutions using Institutional Storage (not NII Storage).
If no default max quota is configured, the system falls back to the global DEFAULT_MAX_QUOTA setting.
Changes
QA Notes
Documentation
Side Effects
Ticket
57860