[GRDM-61058] 削除済み項目 metadata-access-rights の残存によるWEKOエクスポート失敗の修正#752
Open
yacchin1205 wants to merge 2 commits into
Open
[GRDM-61058] 削除済み項目 metadata-access-rights の残存によるWEKOエクスポート失敗の修正#752yacchin1205 wants to merge 2 commits into
yacchin1205 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
削除済みの質問
grdm-file:metadata-access-rightsが古いメタデータ（items[].data）に残っているため、WEKO のメタデータ生成時にKeyError('Question grdm-file:metadata-access-rights not found')が発生する問題の修正。あわせて、creatorsが空文字""のときに姓名分割 migration0267がJSONDecodeErrorで失敗する問題も修正。Changes
0270_remove_metadata_access_rightsを追加し、e-Rad スキーマのFileMetadata/Registration/DraftRegistrationからgrdm-file:metadata-access-rightsキーを除去（既存のFileMetadataMigratorを利用）transform_name_fields_itemでcreatorsが空文字""の場合をガードし、json.loads("")を呼ばず[]として扱うQA Notes
Documentation
None
Side Effects
None
Ticket
GRDM-61058