[GRDM-60941] Fix: auto-input range for Read IdP Profile#756
Draft
ndnhat1 wants to merge 1 commit into
Draft
Conversation
…「IdPプロフィールから読込み」リンクの自動入力範囲について: Fix IDP Japanese fields (institution_ja/department_ja) not auto-filled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of these changes is to allow the "Read IdP Profile" button on the Employment tab to automatically populate Japanese-language fields (
institution_ja,department_ja) from the IdP (Shibboleth) attributes stored at login.Changes
ListViewModel.unserialize()to storeidp_attr_institution_jaandidp_attr_department_jafrom the API response, in addition to the already-storedidp_attr_institutionandidp_attr_department.ListViewModel.setContentFromIdP()to writeinstitution_jaanddepartment_jainto the content model when the corresponding IdP attribute is non-empty.QA Notes
Documentation
Side Effects
Ticket
60941