Skip to content

Navigation Menu

Appearance settings

- AI CODE CREATION
  GitHub CopilotWrite better code with AI
  GitHub Copilot appDirect agents from issue to merge
  MCP Registry^NewIntegrate external tools
- DEVELOPER WORKFLOWS
  ActionsAutomate any workflow
  CodespacesInstant dev environments
  IssuesPlan and track work
  Code ReviewManage code changes
- APPLICATION SECURITY
  GitHub Advanced SecurityFind and fix vulnerabilities
  Code securitySecure your code as you build
  Secret protectionStop leaks before they start
- EXPLORE
  Why GitHub
  Documentation
  Blog
  Changelog
  Marketplace
View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Uh oh!

There was an error while loading. Please reload this page.

RConsortium / S7 Public

Notifications You must be signed in to change notification settings
Fork 49
Star 489

Code
Issues 24
Pull requests 18
Actions
Security and quality
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security and quality
Insights

Polish S4-backed S7 edge cases#720

Draft

t-kalinowski wants to merge 132 commits into

mainRConsortium/S7:mainfrom

s4-extends-s7-compat-fixesRConsortium/S7:s4-extends-s7-compat-fixesCopy head branch name to clipboard

Conversation Commits132 (132)Checks Files changed

Draft

Polish S4-backed S7 edge cases#720
t-kalinowski wants to merge 132 commits into
mainfrom
s4-extends-s7-compat-fixes

Commits

Commits on Jun 23, 2026

use isClassUnion() instead of direct class check
lawremi
committed
pass className attribute directly to preserve package
lawremi
committed
since proper S4 classes can extend old classes, be stricter when reducing to an S3 class, and use methods::extends() to capture the entire class vector, not just the first class
lawremi
committed
fix is_oldClass() and use it in S4_to_S7_class()
lawremi
committed
initial implementation passing a simple test that does not depend on @() behavior, which needs to change in base R.
lawremi
committed
route S4 class registration through S4_register() and setOldClass(); S4_register() can now communicate any S7 class structure through the S4class= argument.
lawremi
committed
add a .lintr.R to allow for our symbol naming convention
lawremi
committed
S4-derived classes gain an initialize() method that mimics the default initialize() except uses the S7 property setting path.
lawremi
committed
call S4_register() automatically on S7 derivatives of S4 classes; fix parent object construction in constructor.
lawremi
committed
add some detailed notes on S4 compatibility to docs
lawremi
committed
fix S7 inheritance checks after rebase
lawremi
committed
drop the S7_object case from S4_register
lawremi
committed
docs: recommend use of initialize() when working with S7 derivatives of S4
lawremi
committed
clean up inheritance logic changes
lawremi
committed
just remove classes that exist instead of using try()
lawremi
committed
update the global variables for our use of @, which still confuses codetools
lawremi
committed
clean up constructor generation
lawremi
committed
fix test guarding against extension of S4 classes
lawremi
committed
allow abstract classes to inhert from virtual S4 classes
lawremi
committed
clean up S4 subclass setOldClass() registration; now supports more complex hierarchies
lawremi
committed
more tweaks to subclass registration
lawremi
committed
make S7_class_name robust to invocation at package build time
lawremi
committed
reformat
lawremi
committed
convert() falls back to methods::as()
lawremi
committed
correct S4 class name for 'to'
lawremi
committed
add test
lawremi
committed
convert_up() can convert an S4-derived S7 object to an S4 object
lawremi
committed
clean up and test restricted methods::as() fallback to convert()
lawremi
committed
S4_register() returns the name of the class it registered, which can be convenient for passing to methods package functions
lawremi
committed
rename S4_transient_prototype_class to S4_register_prototype_class and have it return the class name.
lawremi
committed
support class unions in S4_register()
lawremi
committed
make S4_class() return a methods-friendly class name and have it handle unions, particularly class_numeric
lawremi
committed
support S4 classes extending S7 classes
lawremi
committed
move away from do.call(setClass, ...); package is not needed on the prototype class
lawremi
committed
revert unnecessary direct attr() access
lawremi
committed
move a couple more S4 helpers from methods-register.R to S4.R
lawremi
committed
S7 classes inherit S4 class unions from S4 parents directly, which simplifies the S4 -> S7 -> S4 inheritance case.
lawremi
committed
avoid inherited slot conflicts in the S4->S7->S4 inheritance pattern
lawremi
committed
instead of forwarding S4 class unions into S7 classes, we enable S4_union_class() to find existing S4 unions.
lawremi
committed
update test snapshot after rebase
lawremi
committed
represent inheritance from S7_object at the S4 level
lawremi
committed
since @<- will dispatch to S7 setting even on S4 objects (derived from S7), we need to use R_do_slot_assign so that a NULL value does not delete the S4 slot.
lawremi
committed
inherits2() in prop.c handles S4 object case where class attribute is stored in the .S3Class slot.
lawremi
committed
tweaks to validObject hooks to support additional inheritance patterns
lawremi
committed
in obj_type(), isS4() takes precedence over has_S4_class(), since an S4 object is just that, even if it inherits from an S7 class and thus carries an S7_class slot.
lawremi
committed
restore method-register-S4.R; got lost in the rebase shuffle
lawremi
committed
prop storage now uses the S4 sentinel for NULL for low-level compatibility with S4; arguably a generally better approach since it avoids adding and deleting attributes based on whether the value is…
lawremi
committed
push S4 validation guard down into validate() so that it works for validate() as well as validObject()
lawremi
committed
Define S4 prototype on the ::S4Slots old class based on property defaults. We evaluate these if they are language objects, so S7 classes extending or being extended by S4 classes need to ensure tha…
lawremi
committed
mark the subclass old class as virtual, because there should never be an S4 instance of that class (old classes are virtual normally but not in this case since we pass an S4Class prototype)
lawremi
committed
give convert_up() a general as()-based fallback like convert()
lawremi
committed
make the ::S4Slots class non-virtual to enable more convenient construction
lawremi
committed
drop the up cast coercions (dead end) and instead ensure full slot representation along the old class chain
lawremi
committed
S3 method registration will also register an S4 method when the generic is internal and an element of the signature has an S4 ancestor. This is needed because internal generics will favor S4 method…
lawremi
committed
abstract S7 classes deriving from S4 classes are represented as ordinary S4 classes instead of old classes, because an old class implies an S3 instance of the object can exist, ie, there can be an …
lawremi
committed
old classes were missing S7_class as a declared slot, which can cause it to get stripped during S4 upcasting, breaking the S7 object
lawremi
committed
shorten the S4 registration helper name
lawremi
committed
allow multi-argument signature on internal generics via S4 generic definition
lawremi
committed
S4_initialize sets slots that aren't properties using slot<-, not prop<-
lawremi
committed
@<- supports setting slots on S4 objects
lawremi
committed
S4_validate_shim() does not try to validate objects from a "cousin" S7 class
lawremi
committed
adapt validObject() call to S7 validate contract
lawremi
committed
eliminate S7_object::S4Slots from hierarchy to simplify inheritance; in principle, there should only be one ::S4Slots shim for each S4 derivative of an S7 class
lawremi
committed
doc updates
lawremi
committed
wording tweak

lawremi
and
hadley
committed
Another wording tweak

lawremi
and
hadley
committed
rename is_multi_arg_signature to is_plain_list to clarify its (more general) purpose
lawremi
committed
clarify S4_register() by moving early returns earlier
lawremi
committed
move S4 inheritance guidance to the compatbility vignette
lawremi
committed
massive simplification: no longer define ::S4Slots variant to enable S4 to inherit from S7; there's just two types of classes: the stub old class and the reified old class. The former for when only…
lawremi
committed
add NEWS entry
lawremi
committed
post-rebase cleanup
lawremi
committed
revert accidental reversion of switch to := syntax
lawremi
committed
tighten up a test
lawremi
committed
fix local_S4_class(where=); bug was exposed by our stricter version of S4_remove_classes().
lawremi
committed
API rework: S4_register() always includes properties as slots (what contains=TRUE used to do), which ensures that classes are always able to be used as S4 superclasses. Introduce a separate helper …
lawremi
committed
fix regression from introduction of external generics
lawremi
committed
update for rename of @S7_class to @_S7_class
lawremi
committed

Commits on Jun 24, 2026

Fix S4 bridge review findings
t-kalinowski
committed
Fix S4 compatibility review regressions
t-kalinowski
committed
Fix S4 compatibility regressions
t-kalinowski
committed
Address S4 property review findings
t-kalinowski
committed
Fix S4 storage edge cases
t-kalinowski
committed
Fix S4 parent initialization and defaults
t-kalinowski
committed
Fix S4 deferred defaults
t-kalinowski
committed
Reject internal S4 metadata during upcasts
t-kalinowski
committed
Fix S4 slot storage and S7 marker checks
t-kalinowski
committed
Fix S4 renamed slots and abstract parent registration
t-kalinowski
committed
Fix S7/S4 abstract dispatch and virtual initialization
t-kalinowski
committed
Fix S4 registration regressions
t-kalinowski
committed
Fix S4 package identity regressions
t-kalinowski
committed
Fix S4 initialization metadata handling
t-kalinowski
committed
Fix S4 subclass default initialization
t-kalinowski
committed
Fix S4 initialization review findings
t-kalinowski
committed
Fix S4 inheritance matching and dispatch markers
t-kalinowski
committed
Fix S4 slot validation and local generic registration
t-kalinowski
committed
Fix S4 bridge validation regressions
t-kalinowski
committed
Fix S4 registration and data-part collisions
t-kalinowski
committed
Fix S4 registration and validation review findings
t-kalinowski
committed
Fix S4-backed registration and validation
t-kalinowski
committed
Fix S4 registration review findings
t-kalinowski
committed
Defer S4 validation during initialization
t-kalinowski
committed
Preserve S4 class package during validation
t-kalinowski
committed
Fix S3 S4 registration matching
t-kalinowski
committed
Fix S4 name identity checks
t-kalinowski
committed
Preserve package-qualified S4 class identities
t-kalinowski
committed

Commits on Jun 25, 2026

Reject S4 slot accessor overrides
t-kalinowski
committed
Fix S4-backed S7 validation and data parts
t-kalinowski
committed
Fix S4 data-part and validity edge cases
t-kalinowski
committed
Fix S4 union package identity
t-kalinowski
committed
Fix S4 constructor review findings
t-kalinowski
committed
Preserve S7_object inheritance for data-part S4 shims
t-kalinowski
committed
Fix S4 union registration and validity skips
t-kalinowski
committed
Fix S4 union identity matching
t-kalinowski
committed
Fix S4-backed S7 invariants
t-kalinowski
committed
Reject S4 parents with implicit data parts
t-kalinowski
committed
Avoid reinitializing S4 validity proxies
t-kalinowski
committed
Fix S4 registration review findings
t-kalinowski
committed
Fix installed S4 compatibility checks
t-kalinowski
committed
Fix S4 registration storage handling
t-kalinowski
committed
Avoid methods C entry point for S4 validity
t-kalinowski
committed
Preserve S7 property names through S4 parents
t-kalinowski
committed
Refresh stale S7 property class registration
t-kalinowski
committed
Fix S4 data parts and union subclasses
t-kalinowski
committed
Fix S4/S7 registration and validation edge cases
t-kalinowski
committed
Preserve S4 .S3Class slots for S7 children
t-kalinowski
committed
Preserve S4 data part attributes
t-kalinowski
committed
Check S4 slot types for S7 subclasses
t-kalinowski
committed
Preserve S7_class property when upcasting
t-kalinowski
committed
Fix S4 data-part replacement and contains validation
t-kalinowski
committed
Simplify S4 compatibility helpers
t-kalinowski
committed
Reduce S4 compatibility test duplication
t-kalinowski
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.