Skip to content

Enforce claude md requirement - #48

Merged
ikrispin merged 9 commits into
mainfrom
enforce-claude-md-requirement
Mar 24, 2026
Merged

Enforce claude md requirement#48
ikrispin merged 9 commits into
mainfrom
enforce-claude-md-requirement

Conversation

@ikrispin

@ikrispin ikrispin commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added validate_claude_md() to scripts/validate_structure.py - checks CLAUDE.md existence, required sections (Skill-First Rule, Intent Routing, MCP Servers, Global Rules), and intent routing completeness for every skill
  • Updated root CLAUDE.md pack architecture tree to include CLAUDE.md as a standard file, and added it as a required step in "Creating a New Agentic Pack" and "Adding a Skill" workflows
  • Added Design Principle 11 (Pack-Level CLAUDE.md) to SKILL_DESIGN_PRINCIPLES.md with required sections and update-on-new-skill rule

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-virt
  • rh-ai-engineer
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (.mcp.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

@ikrispin
ikrispin requested a review from r2dedios March 23, 2026 14:36

@r2dedios r2dedios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just a couple of comments to check from my side :)

Comment thread scripts/validate_structure.py Outdated
Comment on lines 114 to 118

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to include here also the model and color fields for the skill description?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point: cff4a26

Comment thread scripts/validate_structure.py
Comment thread SKILL_DESIGN_PRINCIPLES.md
Comment thread scripts/validate_structure.py Outdated
Comment on lines 128 to 151

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part is already covered by scripts/run-skill-linter.sh

@r2dedios

Copy link
Copy Markdown
Contributor

@r2dedios r2dedios added the enhancement New feature or request label Mar 24, 2026
@ikrispin
ikrispin merged commit 661d252 into main Mar 24, 2026
1 of 2 checks passed
@ikrispin
ikrispin deleted the enforce-claude-md-requirement branch March 24, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants