Skip to content

Rh virt/snapshots skills - #7

Merged
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
r2dedios:rh-virt/snapshots-skills
Feb 24, 2026
Merged

Rh virt/snapshots skills#7
dmartinol merged 2 commits into
RHEcosystemAppEng:mainfrom
r2dedios:rh-virt/snapshots-skills

Conversation

@r2dedios

Copy link
Copy Markdown
Contributor

Summary

Refactored rh-virt skills to align with Claude Code design principles and added complete VM snapshot management.

Key Changes

New Skills (4)

  • vm-snapshot-create - Create VM snapshots with storage analysis
  • vm-snapshot-list - List snapshots across namespaces
  • vm-snapshot-restore - Restore VMs with safety confirmations
  • vm-snapshot-delete - Delete snapshots to free storage

Standardization

  • Renamed vm-creator → vm-create for consistency
  • All 9 skills now comply with Claude Code Design Principles:
    • Correct section ordering
    • Anti-patterns in frontmatter
    • Document consultation patterns
    • MCP-first approach with precise parameters
    • Human-in-the-Loop for critical operations

SKILL_TEMPLATE.md Enhancement

  • Integrated all 7 Claude Code Design Principles
  • Added 67-point validation checklist
  • Updated Document Consultation to REQUIRED (lists 6 troubleshooting docs)
  • Enhanced with exact parameter format examples

@r2dedios
r2dedios requested a review from dmartinol February 19, 2026 09:08
@r2dedios r2dedios self-assigned this Feb 19, 2026
@r2dedios r2dedios added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 19, 2026
@r2dedios
r2dedios marked this pull request as ready for review February 20, 2026 00:25
@r2dedios

r2dedios commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

Merge this PR #6 first

…efactored rh-virt skills based on repo's design principles, and Claude's skill guidelines

Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
r2dedios force-pushed the rh-virt/snapshots-skills branch from a84d42b to 9c42de9 Compare February 23, 2026 09:16
@r2dedios

Copy link
Copy Markdown
Contributor Author

@dmartinol branch rebased with main

- [storage-errors.md](../../docs/troubleshooting/storage-errors.md) - VM cloning failure scenarios, storage provisioning issues, and DataVolume cloning errors (optionally consulted when cloning operations fail)
- [Troubleshooting INDEX](../../docs/troubleshooting/INDEX.md) - Navigation hub for discovering additional error categories when encountering unexpected issues outside the categories above
- [OpenShift Virtualization Cloning](https://docs.openshift.com/container-platform/latest/virt/virtual_machines/cloning_vms/virt-cloning-vm.html)
- [OpenShift Virtualization Cloning](https://docs.redhat.com/en/documentation/openshift_container_platform/4.21/html-single/virtualization/index#virt/virtual_machines/cloning_vms/virt-cloning-vm.html)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should embed this doc into our skill, pls take a note

- [storage-errors.md](../../docs/troubleshooting/storage-errors.md) - Storage deletion strategies and PVC cleanup procedures (optionally consulted when storage deletion fails)
- [Troubleshooting INDEX](../../docs/troubleshooting/INDEX.md) - Navigation hub for discovering additional error categories when encountering unexpected issues outside the categories above
- [OpenShift Virtualization Documentation](https://docs.openshift.com/container-platform/latest/virt/about_virt/about-virt.html)
- [OpenShift Virtualization Documentation](https://docs.redhat.com/en/documentation/openshift_container_platform/4.21/html-single/virtualization/index#virt/about_virt/about-virt.html)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Comment thread rh-virt/SKILL_TEMPLATE.md

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should move this at the root level. it can be part of the work you do for the code linting

Comment thread rh-virt/SKILL_TEMPLATE.md
- Makes dependencies explicit for troubleshooting
- Enables proper error handling when dependencies missing

### Required MCP Servers

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already defined above?

## Prerequisites

**Required MCP Server**: `openshift-virtualization` ([OpenShift MCP Server](https://github.com/openshift/openshift-mcp-server))

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@dmartinol
dmartinol merged commit 7c25725 into RHEcosystemAppEng:main Feb 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants