APPENG-3315 Allow the user to insert custom Amazon dataset#12
Merged
Conversation
This has been fixed by APPENG-3363
itay1551
requested changes
Jul 16, 2025
| import pandas as pd | ||
| from feast import FeatureStore | ||
|
|
||
| from models import data_util |
Collaborator
There was a problem hiding this comment.
This will do problems on the backend which copy into the public/, need to add to the copy the right path
Contributor
Author
There was a problem hiding this comment.
Right! Good catch.
We copy the models and service directory on on /* in the workflow container and on /public/* in the backend container...
Ideally I think that eventually we should try to have the same scaffolding.
Contributor
Author
|
Thanks @itay1551 for the review. I added a commit with the workaround for the import. |
Contributor
Author
|
All (included the last workaround) tested: https://rhods-dashboard-redhat-ods-applications.apps.ai-dev02.kni.syseng.devcluster.openshift.com/pipelineRuns/rec-sys-fax/runs/13e78e39-fa7c-46e9-8e59-47334e065efe |
Contributor
Author
|
Merged thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/APPENG-3315