tests: compile-tests should only be executed in building machine#10573
Merged
jcarrano merged 3 commits intoDec 10, 2018
Conversation
If the file does not exist, because of concurrency issues, there is no error. So verify it is there for good measures.
Without the protection, the host system also tries to execute the tests.
Without the protection, the host system also tries to execute the tests.
jcarrano
approved these changes
Dec 7, 2018
jcarrano
left a comment
Contributor
There was a problem hiding this comment.
Tested both commands, all good.
Contributor
Author
|
I updated the test description as I pasted the same command twice for the first one. Also I forgot to say that the fail case was with the first commit applied. Does not change what works, just how to show it failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When building with
BUILD_IN_DOCKERthecompile-testswere also tried to be executed on the host machine which had concurrency issues when done in parallel and also fails if you do not have the toolchain.I also inlined added a change that verify the test file exists as the test would silently compare the error string instead of the real output.
Testing procedure
Using the first commit only:
On a clean environment these both fail:
And with the following, the tests are executed both in docker and the build machine
Issues/PRs references
Found while building in docker on a machine without toolchain and also again during #10344 testing.