cpu/sam0_common: remove unneeded GCLK_SLOW setup in i2c driver#10839
Merged
Conversation
dylad
added
Impact: minor
Contributor
|
It makes sense but I will need some time before I can really test it. |
Member
Author
Thanks @MrKevinWeiss ! This is not an urgent PR. This can be done after the release. |
Contributor
|
I've tested this on a SAML21 based custom board that has some EEPROM chips on I2C and all seems fine |
Member
Author
|
Thanks for testing @fedepell ! |
Contributor
|
Uh oh, I can test when I get back. Sorry I forgot about it. |
Contributor
|
I can get to it on Thursday or Friday! |
Member
Author
|
@MrKevinWeiss this would be perfect ! |
MrKevinWeiss
added
CI: ready for build
MrKevinWeiss
approved these changes
Mar 28, 2019
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
Contributor
There was a problem hiding this comment.
Tested on the samr30-xpro with the scope and it shows 100kHz, the datasheets indicated that it isn't needed for this application. It appears it got merged in with initial commits.
ACK!.
Member
Author
|
Thanks for merging this ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes the SERCOMx_GLCK_SLOW clock setup from the I2C driver.
According to SAML21, SAMD21 and SAML10 datasheets, this clock is used for SMBus timeouts features but RIOT doesn't use them at all.
Look for
GCLK_SERCOM_SLOWwithin the datasheet for more information.In addition, this clock should be feed with 32kHz clock source not xx MHz (which is the case now)
Testing procedure
Pick the SAM0 board you want, play with any I2C sensors.
Issues/PRs references
Found this while adding I2C support for SAML10/SAML11 in #10653