Skip to content

Release 2019.01 notes#10871

Merged
aabadie merged 1 commit into
RIOT-OS:masterfrom
aabadie:pr/release_notes_2019.01
Feb 14, 2019
Merged

Release 2019.01 notes#10871
aabadie merged 1 commit into
RIOT-OS:masterfrom
aabadie:pr/release_notes_2019.01

Conversation

@aabadie

@aabadie aabadie commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Contribution description

This PR is the initial draft for the 2019.01 release notes.

Every maintainer is invited to update this PR by either opening PRs against my fork or by directly pushing into my branch.

You can get the complete list of closed issues and PRs tagged for this release in https://github.com/RIOT-OS/RIOT/milestone/25?closed=1.

@aabadie aabadie added the Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) label Jan 25, 2019
@aabadie aabadie changed the title Release 2019.01 note Release 2019.01 notes Jan 25, 2019
@aabadie aabadie force-pushed the pr/release_notes_2019.01 branch from 82675ea to d023c52 Compare January 26, 2019 20:20
@aabadie aabadie added the Community: help wanted The contributors require help from other members of the community label Jan 27, 2019
Comment thread release-notes.txt Outdated
miri64
miri64 previously requested changes Jan 29, 2019
Comment thread release-notes.txt Outdated
Comment thread release-notes.txt
Comment thread release-notes.txt
Comment thread release-notes.txt
Comment thread release-notes.txt
Comment thread release-notes.txt Outdated
Comment thread release-notes.txt
@aabadie aabadie force-pushed the pr/release_notes_2019.01 branch 2 times, most recently from 4cf243b to ad90067 Compare February 1, 2019 18:40
@cladmi

cladmi commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

I added a commit with my contributions. I detailed to what tasks they are related to in the commit message.

@aabadie aabadie force-pushed the pr/release_notes_2019.01 branch from 328c69f to 1f0a1fe Compare February 13, 2019 20:44
@emmanuelsearch emmanuelsearch force-pushed the pr/release_notes_2019.01 branch from 35f6229 to e80f43a Compare February 14, 2019 10:01
Comment thread release-notes.txt Outdated
About 387 pull requests with about 912 commits have been merged since the last
release and about 36 issues have been solved. 54 people contributed with code
in 92 days. Approximately 1525 files have been touched with 171769 insertions
and 46121 deletions.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these numbers recent or just copy-pasted?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a quick check here shows more like 425 PRs merged, and 1285 commits since the 2018.10 release (on Nov. 13th, right?)

I used the below methods, taking:

  • for the merged PR count, this github API call
  • for the number of commits, the below git command
    $ git rev-list --after="2018-11-13T00:00" --count master

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

912 commits is right according to

./dist/tools/release-stats/release-stats.sh 2019.01-devel 2019.01-RC3

But the rest is off a bit. The number of issues is also too small and we got 429 PRs merged

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just saw your comment now ^^"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The results of the release stats script were

    <tr>
        <td>2019.01-RC3</td>
        <td>7131</td>
        <td>2010903 (1914102)</td>
        <td>110 days</td>
        <td>912</td>
        <td>1554 files changed, 176241 insertions(+), 50593 deletions(-)</td>
        <td>199 Martine Lenders<br />
            128 Alexandre Abadie<br />
            112 Gunar Schorcht<br />
            48 Gaëtan Harter<br />
            48 Kees Bakker<br /></td>
    </tr>

btw. They are meant for this table. So fourth cell is the development time, fifth the number of commits, and sixth the diff stats.

Number of contributors can be counted with

$ git shortlog --no-merges -n -s "2019.01-devel".."2019.01-RC3" | wc -l
54

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git rev-list --after="2018-11-13T00:00" --count master

This method also includes things that are already merged in master but not backported to the release branch. To get the number of PRs I used the PR listed in GitHub but filtered on the Milestone 2019.01. I tried to include everything I could but maybe some were missed.

The number of issues is also too small

because it only includes the issues labelled as bug.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the number of files touched and global changeset, I did:

$ git diff --shortstat 2019.01-devel..2019.01-RC3
 1525 files changed, 171769 insertions(+), 46121 deletions(-)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the number of days. Do we agree with the other numbers ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About git diffstats, dist/tools/release-stats/release-stats.sh uses the --no-renames option. IIUC, with this, the statistics also includes files that were just renamed. Why not, so I'll update the values.

@emmanuelsearch

Copy link
Copy Markdown
Member

@aabadie just added a synopsis (last explicit TO DO left here ;)

@aabadie aabadie added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Feb 14, 2019
@aabadie

aabadie commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

@emmanuelsearch, @miri64, last thing we need is a review here before the release.

@emmanuelsearch emmanuelsearch added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Feb 14, 2019
@emmanuelsearch emmanuelsearch self-assigned this Feb 14, 2019

@emmanuelsearch emmanuelsearch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

Comment thread release-notes.txt
Cortex-M boards supported by RIOT. Support for several new boards and new sensors
was added, as well as for the new CPU architecture Armv8-M (Cortex-M23). Last
but not least, this release contains a number of bug fixes and enhances test
automation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this paragraph is fine with everyone, I'm fine with this PR ;)

Co-authored-by: Emmanuel Baccelli <emmanuel.baccelli@inria.fr>
Co-authored-by: Gaëtan Harter <gaetan.harter@fu-berlin.de>
Co-authored-by: Martine Lenders <m.lenders@fu-berlin.de>
Co-authored-by: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>
Co-authored-by: Peter Kietzmann <peter.kietzmann@haw-hamburg.de>
@aabadie aabadie force-pushed the pr/release_notes_2019.01 branch from 07a557e to 5cfdf0c Compare February 14, 2019 15:59
@aabadie

aabadie commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

Please squash

Done :)

@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 14, 2019
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 14, 2019
@miri64

miri64 commented Feb 14, 2019

Copy link
Copy Markdown
Member

@emmanuelsearch, @miri64, last thing we need is a review here before the release

Well, we also need a backport of this ;)

@miri64 miri64 dismissed their stale review February 14, 2019 16:20

My comment was addressed. I'm fine with @emmanuelsearch's paragraph.

@aabadie

aabadie commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

@miri64, since you co-authored the release note commit, you reach the 200 commits included in this release, congrats!

@aabadie

aabadie commented Feb 14, 2019

Copy link
Copy Markdown
Contributor Author

Let's go!

@aabadie aabadie merged commit 288e29a into RIOT-OS:master Feb 14, 2019
Comment thread release-notes.txt
About this release:
===================

The 2019.01 release includes a number of new features including DMA support on

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late review.

I think the IPv6 refactor should be also included. The project was finished during January, just before feature freeze

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's not highlighted but it's added in the list of changes here. I think it's fine even if not perfect.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sure ;)

@aabadie aabadie deleted the pr/release_notes_2019.01 branch February 14, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: help wanted The contributors require help from other members of the community Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants