cpu/saml21: extend and fix exti configuration for saml21 variants [backport 2019.01]#10907
Merged
aabadie merged 1 commit intoJan 31, 2019
Conversation
Added a configuration for saml21g18a and fixes the configuration for samr30g18a (cherry picked from commit 7cf3510)
aabadie
added
Area: cpu
Contributor
Author
|
I pushed the branch by mistake to the upstream repo and removed it after. My personal fork is not called origin locally, I messed up with that when using the backport script PR. |
Contributor
Author
|
@miri64, can you review this and merge ? Thanks! |
Contributor
Author
|
or maybe @emmanuelsearch ? |
Contributor
Author
|
ping, I can't ACK my own PR... And there's another backport in the pipe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10794
Contribution description
While reviewing #10653, I tested different things on samr30-xpro to verify there were no regressions introduced by the port. Indeed, the saml1x works relies a lot on saml21 cpus and samr30 are fully based on saml21 cpus (they are the same with a radio, like samr21 compared to samd21).
During my tests, I noticed the
tests/buttonswas broken: the on-board button gpio couldn't be initialized with IRQ.After a look at the code, I found that the exti configuration was the same for all types of saml21 cpus which is wrong according the datasheet.
This PR is adding the missing configuration and, in the meantime, it fixes the broken
tests/buttonsapplication on samr30-xpro boards.Testing procedure
tests/buttonsapplication on samr30-xpro/saml21-xpro and verify that it works. on master, with samr30-xpro, you get an initialization failure, with this PR everything works smoothly.Issues/PRs references
Found while reviewing #10653