Skip to content

tests/periph_flashpage: add RWWEE automatic test if hw supports it#11307

Merged
dylad merged 1 commit into
RIOT-OS:masterfrom
fedepell:rwwee_autotests
May 4, 2019
Merged

tests/periph_flashpage: add RWWEE automatic test if hw supports it#11307
dylad merged 1 commit into
RIOT-OS:masterfrom
fedepell:rwwee_autotests

Conversation

@fedepell

@fedepell fedepell commented Mar 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Contribution description

This small PR adds automatic tests for RWWEE flash for which support was added in #10884 . The test checks if the board implements this feature and if so runs and automatic test.
While adding this a small improvement was done that improves its stability: before sending commands we make sure the command prompt is reached.

I tested this succesfully on a board with RWWEE (saml21-xpro) and one without (stk3700).

Testing procedure

Automatic tests in tests/periph_flashpage can be built and executed

cd tests/periph_flashpage
BOARD=xyz make all flash test

Issues/PRs references

Adds automatic testing for #10884 improving #10106

@fedepell

fedepell commented Mar 29, 2019

Copy link
Copy Markdown
Contributor Author

@dylad : just a small addition for the RWWEE addition so we have it in the automatic test.

@miri64 miri64 added Area: tests Area: tests and testing framework Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: drivers Area: Device drivers labels Mar 29, 2019
@dylad dylad self-assigned this Apr 1, 2019
@dylad dylad added this to the Release 2019.04 milestone Apr 1, 2019
@dylad dylad modified the milestones: Release 2019.04, Release 2019.07 May 4, 2019
dylad
dylad approved these changes May 4, 2019
View reviewed changes

@dylad dylad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK.

@dylad dylad added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 4, 2019
@dylad

dylad commented May 4, 2019

Copy link
Copy Markdown
Member

and go.

@dylad dylad merged commit c49e72a into RIOT-OS:master May 4, 2019
@fedepell

fedepell commented May 5, 2019

Copy link
Copy Markdown
Contributor Author

@dylad thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylad dylad dylad approved these changes

Assignees

@dylad dylad

Labels

Area: drivers Area: Device drivers Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2019.07

Development

Successfully merging this pull request may close these issues.

3 participants

@fedepell @dylad @miri64