Skip to content

drivers/at86rf2xx: add support for configuring PHY modes#12185

Closed
benpicco wants to merge 3 commits into
RIOT-OS:masterfrom
benpicco:at86rf2xx-phy_modes
Closed

drivers/at86rf2xx: add support for configuring PHY modes#12185
benpicco wants to merge 3 commits into
RIOT-OS:masterfrom
benpicco:at86rf2xx-phy_modes

Conversation

@benpicco

@benpicco benpicco commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Contribution description

This implements getting & setting O-QPSK options with #12171
This allows for setting the rate mode (values 0-4, for 250, 500, 1000 & 2000 kbit/s operation) as well as chip rate (1000 kchip/s and 400 kchip/s for O-QPSK and 600 kchip/s and 300 kchip/s for BPSK).

The proprietary rate mode 2 on at86rf233 is compatible with the legacy high data rate mode on at86rf215.

Testing procedure

Or on samr30-xpro you should now be able to to the following:

ifconfig 7 set rate_mode 2
ifconfig 7 set chip_rate 400

You should get

 Iface  7  HWaddr: 34:82  Channel: 0  Page: 2  NID: 0x23 PHY: O-QPSK 
            chip rate: 400 rate mode: 2 (legacy) 
           Long HWaddr: 79:7A:34:2F:9D:73:B4:82

On samr21-xpro, setting the chip_rate should fail.

Issues/PRs references

depends on #12171

@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first Area: drivers Area: Device drivers labels Sep 9, 2019
@miri64

miri64 commented Sep 9, 2019

Copy link
Copy Markdown
Member

@jia200x is this a duplicate of #12069?

@benpicco

benpicco commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

@miri64 no this is to expose some modulation options that the chip provides to ifconfig.

@PeterKietzmann

Copy link
Copy Markdown
Member

@jia200x I think this is a candidate for you

@jia200x

jia200x commented Sep 24, 2019

Copy link
Copy Markdown
Member

I'm back!

@jia200x is this a duplicate of #12069?

Not, not at all. #12069 just changes the representation of PHY states. This PR adds the means for configuring new PHY modes.

@stale

stale Bot commented Mar 27, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale Bot added the State: stale State: The issue / PR has no activity for >185 days label Mar 27, 2020
@stale stale Bot closed this Apr 27, 2020
@benpicco benpicco deleted the at86rf2xx-phy_modes branch May 8, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers State: stale State: The issue / PR has no activity for >185 days State: waiting for other PR State: The PR requires another PR to be merged first Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants