Skip to content

boards/atmega256rfr2-xpro: initial support#12639

Merged
maribu merged 5 commits into
RIOT-OS:masterfrom
aabadie:pr/boards/atmega256rfr2
Nov 5, 2019
Merged

boards/atmega256rfr2-xpro: initial support#12639
maribu merged 5 commits into
RIOT-OS:masterfrom
aabadie:pr/boards/atmega256rfr2

Conversation

@aabadie

@aabadie aabadie commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

Contribution description

This PR is adding an initial support for the ATmega256RFR2 Xplained pro board.

Interesting things with this board:

  • it allows to test the atmega256rfr2 cpu that has no board support for the moment
  • it provides an integrated edbg programmer, compatible with avrdude: the board can be easily flashed and even reset (debug not tested yet).
  • it provides a radio (untested yet)

I ran the compile_and_test_for_board.py script and it reports several problems. I'll have a look at that later.

The PR is marked as a draft until the board is fully tested/configured.

Testing procedure

  • A green Murdock
  • Allowed automatic tests are passing

Issues/PRs references

Based on #12608 to avoid having to update BLACKLIST_BOARD variables that will be removed anyway once merged.

@aabadie aabadie added Type: new feature The issue requests / The PR implemements a new feature for RIOT Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: boards Area: Board ports labels Nov 4, 2019
@aabadie aabadie requested review from benpicco and maribu November 4, 2019 14:08
@aabadie aabadie force-pushed the pr/boards/atmega256rfr2 branch from f6ad8c7 to a4d4d4d Compare November 4, 2019 14:24
@aabadie aabadie marked this pull request as ready for review November 4, 2019 21:04
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 4, 2019
@aabadie aabadie force-pushed the pr/boards/atmega256rfr2 branch from 87dc5cf to 21ba47c Compare November 4, 2019 21:15
@aabadie

aabadie commented Nov 4, 2019

Copy link
Copy Markdown
Contributor Author

I went a little further here:

This PR is no longer a draft.

@benpicco benpicco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward, good to hear debugging works!

@aabadie

aabadie commented Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing @benpicco. If you don't mind, before merging, I'd like to provide more test results with this board.

@aabadie

aabadie commented Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

I tested a bit the radio with examples/gnrc_networking and it is working well: I was able to ping a RPI with 802.15.4 enabled :)

@aabadie

aabadie commented Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

Failing automatic tests:

Failures during test:
- [tests/bench_runtime_coreapis](tests/bench_runtime_coreapis/test.failed)
- [tests/bitarithm_timings](tests/bitarithm_timings/test.failed)
- [tests/event_wait_timeout](tests/event_wait_timeout/test.failed)
- [tests/evtimer_msg](tests/evtimer_msg/test.failed)
- [tests/gnrc_ipv6_ext](tests/gnrc_ipv6_ext/test.failed)
- [tests/gnrc_ipv6_ext_frag](tests/gnrc_ipv6_ext_frag/test.failed)
- [tests/gnrc_ipv6_fwd_w_sub](tests/gnrc_ipv6_fwd_w_sub/test.failed)
- [tests/gnrc_ndp](tests/gnrc_ndp/test.failed)
- [tests/gnrc_netif](tests/gnrc_netif/test.failed)
- [tests/gnrc_rpl_srh](tests/gnrc_rpl_srh/test.failed)
- [tests/gnrc_sock_dns](tests/gnrc_sock_dns/test.failed)
- [tests/gnrc_tcp](tests/gnrc_tcp/test.failed)
- [tests/isr_yield_higher](tests/isr_yield_higher/test.failed)
- [tests/libfixmath](tests/libfixmath/test.failed)
- [tests/periph_eeprom](tests/periph_eeprom/test.failed)
- [tests/periph_gpio](tests/periph_gpio/test.failed)
- [tests/pipe](tests/pipe/test.failed)
- [tests/pkg_c25519](tests/pkg_c25519/test.failed)
- [tests/pkg_jsmn](tests/pkg_jsmn/test.failed)
- [tests/pkg_lora-serialization](tests/pkg_lora-serialization/test.failed)
- [tests/pkg_micro-ecc](tests/pkg_micro-ecc/test.failed)
- [tests/ps_schedstatistics](tests/ps_schedstatistics/test.failed)
- [tests/pthread_barrier](tests/pthread_barrier/test.failed)
- [tests/stdin](tests/stdin/test.failed)
- [tests/trickle](tests/trickle/test.failed)
- [tests/xtimer_usleep_short](tests/xtimer_usleep_short/test.failed)

I'm looking into them.

riot-ci pushed a commit to riot-ci/RIOT that referenced this pull request Nov 5, 2019
boards/atmega256rfr2-xpro: initial support
@maribu maribu merged commit 66f28d7 into RIOT-OS:master Nov 5, 2019
@aabadie aabadie deleted the pr/boards/atmega256rfr2 branch November 5, 2019 21:42
@aabadie

aabadie commented Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

Too bad, you merged this on a little bit too early: the failing tests revealed a misconfiguration of the clock on that board. Indeed, it provides an external 16MHz oscillator that can be enabled by properly enabling the low fuse byte. I was just testing with this and it's fixing a lot of timeout issues in the tests.

Will provide this in a follow-up PR.

@aabadie

aabadie commented Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

BTW what is @riot-ci exactly ? who is behind this ?

@maribu

maribu commented Nov 6, 2019

Copy link
Copy Markdown
Member

Oh! I had this page open on my phone and never intended to merge it. I guess it unlocked in my pocket. Sorry!

@maribu

maribu commented Nov 6, 2019

Copy link
Copy Markdown
Member

Btw: The debugger included in this board cannot by chance be connected to other external ATmega boards?

@miri64

miri64 commented Nov 6, 2019

Copy link
Copy Markdown
Member

BTW what is @riot-ci exactly ? who is behind this ?

It's the account Murdock uses to access GitHub, so our CI team (@kaspar030, @smlng, ...)

@miri64

miri64 commented Nov 6, 2019

Copy link
Copy Markdown
Member

I think I have access as well, somehow.

@miri64

miri64 commented Nov 6, 2019

Copy link
Copy Markdown
Member

Why are you asking?

@aabadie

aabadie commented Nov 6, 2019

Copy link
Copy Markdown
Contributor Author

Why are you asking?

This message appeared in the PR yesterday:
riot-ci pushed a commit to riot-ci/RIOT that referenced this pull request 13 hours ago

Not sure what this is about.

@miri64

miri64 commented Nov 6, 2019

Copy link
Copy Markdown
Member

Given these two PRs RIOT-OS/RobotFW-tests#20, RIOT-OS/RobotFW-tests#21, I guess @smlng was logged in as the wrong user again ;-).

@miri64

miri64 commented Nov 6, 2019

Copy link
Copy Markdown
Member

I'm wondering however if and why @riot-ci needs push rights to master.

@smlng

smlng commented Nov 6, 2019

Copy link
Copy Markdown
Member

wasn't me, at least I wasn't using the riot-ci user lately (and also shouldn't anyway, other than by mistake). However, that commit or push was not done by me.

@aabadie

aabadie commented Nov 6, 2019

Copy link
Copy Markdown
Contributor Author

The debugger included in this board cannot by chance be connected to other external ATmega boards?

Something can be soldered on the back of the board but that doesn't seem very easy. Of course there's nothing in their user guide about that.

@maribu

maribu commented Nov 6, 2019

Copy link
Copy Markdown
Member

OK, I see. Thanks for the info!

@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants