Skip to content

driver/at86rf2xx use luid_get_eui64 to genenerate EUI#13273

Closed
kfessel wants to merge 1 commit into
RIOT-OS:masterfrom
kfessel:patch-at86rf2xx
Closed

driver/at86rf2xx use luid_get_eui64 to genenerate EUI#13273
kfessel wants to merge 1 commit into
RIOT-OS:masterfrom
kfessel:patch-at86rf2xx

Conversation

@kfessel

@kfessel kfessel commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

using luid_get_eui64 ensures:

  • local admin address bit set
    was done manually before
  • group address bit unset
    was done manually before
  • count eui up
    was missing
    (luid_get counts up byte 0, the bit changes above make
    LSB and LSB<<1 of byte 0 constant -> 4 addresses are the same)

multiple devices will get the same eui
(since the same luid generation is used in in different drivers
it might happen even though different devices are used)

@kfessel kfessel requested review from maribu and miri64 February 3, 2020 15:32
@kfessel

kfessel commented Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

I can't test this.
I searched for similar problems to PR #13232

using luid_get_eui64 ensures:
- local admin address bit set
	was done manually before
- group address bit unset
	was done manually before
- count eui up
	was missing
	(luid_get counts up byte 0, the bit changes above make
	LSB and LSB<<1 of byte 0 constant -> 4 addresses are the same)
@kfessel

kfessel commented Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

typo fixed

@benpicco benpicco added Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Feb 25, 2020
@miri64

miri64 commented Jun 25, 2020

Copy link
Copy Markdown
Member

This seem reasonable, however, there are other PRs like this flying around: #12600

@miri64 miri64 added the State: duplicate State: The issue/PR is a duplicate of another issue/PR label Jun 25, 2020
@kfessel

kfessel commented Jul 2, 2020

Copy link
Copy Markdown
Contributor Author

Yes it is a duplicate since while fixing #13232 i searched for the same problem and found it here. #12600 was also a bit stale a that moment, this is only a partial fix for the Problems.

@miri64

miri64 commented Jul 2, 2020

Copy link
Copy Markdown
Member

#12600 was also a bit stale a that moment, this is only a partial fix for the Problems.

Last comment 16 days ago I wouldn't consider stale in this community 😅. @maribu @benpicco would you be okay with this going in first when bad comes to worse?

@maribu

maribu commented Jul 2, 2020

Copy link
Copy Markdown
Member

Apparently, this was already fixed as side effect by #13362, which was merged to solve the issue with the collisions of the short addresses in INRIAs testbed.

@miri64

miri64 commented Jul 2, 2020

Copy link
Copy Markdown
Member

Then can this be closed?

@maribu

maribu commented Aug 23, 2020

Copy link
Copy Markdown
Member

Then can this be closed?

Yes

@maribu maribu closed this Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers State: duplicate State: The issue/PR is a duplicate of another issue/PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants