tests/unittests: fix GCC compiler bug in core-atomic for SAML1X#13462
Conversation
dylad
added
Type: bug
|
Murdock is happy, please squash |
|
You forgot to remove the saml1x boards from |
Which blacklist are you referring to ? I didn't find it. |
|
The one added by 13a6cfb |
Oh, this PR needs a rebase then... I thought I was blind or something. |
dylad
force-pushed
the
pr/saml1x/fix_unittests
branch
from
f150494 to
33d61a7
Compare
|
Should be good now. |
|
You can squash directly 😉 |
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Murdock will confirm this mitigated the issue for now.
dylad
force-pushed
the
pr/saml1x/fix_unittests
branch
from
33d61a7 to
604356b
Compare
|
@kaspar030 any words before pushing the big button ? |
Let's not forget to re-check on the next toolchain upgrade. Disabling atomics optimization cannot be good. :) |
Co-Authored-By: benpicco <benpicco@googlemail.com>
dylad
force-pushed
the
pr/saml1x/fix_unittests
branch
from
604356b to
fd98443
Compare
I will try to remember it :) But seems like this bug is getting worse on newer toolchain |
really? did you try a gcc-10 |
No but I ported this MCU one year ago and during the port I already had this issue. At this time, only one function was affected but now there is three. |
|
&go. |
|
Thanks @kaspar030 ! |
This reverts RIOT-OS#13462, this workaround is no longer needed with newer GCC version Signed-off-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
19686: sys/string_utils: add memchk() r=maribu a=benpicco 19687: tests/unittests: remove old workaround for SAML1X and gcc9.X bug r=maribu a=dylad ### Contribution description This reverts #13462, this workaround is no longer needed with newer GCC version. ### Testing procedure Try to compile tests/unittests for `saml11-xpro` or `saml10-xpro` ### Issues/PRs references This is a revert of #13462. Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Dylan Laduranty <dylan.laduranty@mesotic.com>
3 participants
Contribution description
This PR provides a quick (dirty ?) fix for SAML1X families and unittests.
In fact, this PR extends a current fix that was there to fix a previous compiler issue when I was porting SAML10/SAML11 MCUs. I don't know if this is the best way to handle it...
Testing procedure
Compile tests/unittests on SAML10 or SAML11 boards.
Issues/PRs references
#13459