tests: blacklist mtd using tests for esp32-wroom-32#15124
Merged
Conversation
kaspar030
added
Type: bug
kaspar030
requested review from
MichelRottleuthner,
aabadie,
fjmolinas,
leandrolanzieri and
smlng
as code owners
benpicco
approved these changes
Sep 30, 2020
benpicco
left a comment
benpicco
left a comment
Contributor
There was a problem hiding this comment.
If nobody comes up with a better solution (those tests succeed locally) this is the easy way out :\
benpicco
reviewed
Sep 30, 2020
kaspar030
force-pushed
the
blacklist_mtd_tests_esp32
branch
from
0282a31 to
cc0523e
Compare
kaspar030
force-pushed
the
blacklist_mtd_tests_esp32
branch
from
cc0523e to
d59fd84
Compare
Contributor
|
Turns out esp* did indeed break by #14754 - we should have trusted the CI on this one 😞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
These tests fail on CI. Blocklisting them for now so CI won't stumble all the time.
Testing procedure
Issues/PRs references
Corresponding issue: #15123