Skip to content

Fix Pages artifact selection when rerunning deployments - #3

Merged
Flink-ddd merged 1 commit into
mainfrom
fix/pages-artifact-retries
Sep 16, 2026
Merged

Flink-ddd merged 1 commit into
mainfrom
fix/pages-artifact-retries

Conversation

@Flink-ddd

@Flink-ddd Flink-ddd commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Rebuilding after configuring rlalign.ai succeeded, but publishing failed because a rerun retained two artifacts named github-pages in the same workflow run.

Give each attempt its own artifact name using github.run_attempt, and pass that same name to the deployment action. This lets the publisher select the newly built site when a deployment is retried.

Validation: the root-domain build and all 16 local resource checks passed before the artifact selection failure. The upload and deployment inputs were checked against the official actions. The existing CI checks both root and project-path builds; deployment will verify the updated artifact selection.

Summary by CodeRabbit

  • Chores
    • Improved GitHub Pages deployment handling by assigning unique artifacts to each deployment attempt.
    • Helps prevent artifact conflicts and supports more reliable publishing when deployments are retried.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e543e3b5-6401-4dd5-96e0-2b66bc355d10

📥 Commits

Reviewing files that changed from the base of the PR and between f192703 and 2c53b87.

📒 Files selected for processing (1)
  • .github/workflows/pages.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The GitHub Pages deployment workflow now assigns a run-attempt-specific artifact name during upload and passes the same name to the deployment action.

Changes

Pages deployment

Layer / File(s) Summary
Configure Pages artifact naming
.github/workflows/pages.yml
The upload step names the artifact github-pages-${{ github.run_attempt }}. The deployment step receives the same value through artifact_name.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2c53b

The workflow change is consistent with the documented Pages artifact inputs and is mergeable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing artifact selection during deployment reruns.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pages-artifact-retries

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.


Comment @coderabbitai help to get the list of available commands.

@Flink-ddd
Flink-ddd merged commit 0bbf6c4 into main Sep 16, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant