rocknix-memory-manager integration#7
Open
aenertia wants to merge 1 commit into
Open
Conversation
Contributor
|
I will make a local build to give this a test on my OGU |
| if (currSwap.empty()) currSwap = "0"; | ||
| swap_size->add(_("DISABLE"), "0", currSwap == "0"); | ||
| swap_size->add(_("AUTO (RAM SIZE)"), "Auto", currSwap != "0" && currSwap != "256" && currSwap != "512" && currSwap != "768" && currSwap != "1024" && currSwap != "2048" && currSwap != "4096" && currSwap != "6144" && currSwap != "8192" && currSwap != "12288" && currSwap != "16384"); | ||
| swap_size->add(_("RESUME (HIBERNATION)"), "Resume", false); |
Contributor
There was a problem hiding this comment.
Please remove the RESUME (HIBERNATION) option
| vm_oc->add(_("ALWAYS (GAME COMPAT)"), "1", false); | ||
| vm_oc->add(_("HEURISTIC (DEFAULT)"), "0", false); | ||
| p->addWithLabel(_("VM OVERCOMMIT"), vm_oc); | ||
| p->addSaveFunc([vm_oc] { system(("rocknix-memory-manager --vm-overcommit \"" + vm_oc->getSelected() + "\"").c_str()); }); |
Contributor
There was a problem hiding this comment.
This is not currently a valid rocknix-memory-manager action
porschemad911
requested changes
Feb 12, 2026
Author
|
Thanks for the feedback - I decided to hold off doing the GUI integration until I had played around with ES bindings more and become a bit more familiar with it so that this doesn't create inadvertently annoying rebase issues later on. Will incorporate into testing before next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.