Upstream merge 2026-09-11 04:27 EDT - #297
Merged
Merged
Conversation
… (#3951) Adds reverse-translation of the new `OpTypeVectorIdEXT` op from `SPV_EXT_long_vector` extension in the Reader. Its component size must be a constant instruction (`OpConstant`/`OpSpecConstant`/`OpSpecConstantOp`). The goal is to cover `OpTypeVectorIdEXT` for all instructions that can use `OpTypeVector` type. However, there's a fundamental difference when it comes to **checking the component count** for these instructions: - We can't check component count in `validate()` methods of these instructions, like they do for `OpTypeVector`-typed results/operands, because the component count is an instruction which must be translated/evaluated to know the values. - We can't _fully_ rely on the `spirv-val` to validate component count for instructions either, because `spirv-val` can't correctly evaluate specialization constants which can be overriden by users via TranslatorOpts. Given these, the component check of `OpTypeVectorIdEXT` for instructions are performed by the Reader during `transValue`. For the same reason, a new `SPIRVTypeVectorIdEXT` class is added, since its state and implementation differ a lot from `SPIRVTypeVector`.
rocm-spirv-translator-merge
Bot
requested review from
AlexVlx,
MrSidims,
lamb-j,
maarquitos14,
mgcarrasco and
steffenlarsen
September 11, 2026 08:27
maarquitos14
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated merge of upstream KhronosGroup/SPIRV-LLVM-Translator main branch.
This PR was created automatically by the upstream-merge workflow.
Important
Merge with "Create a merge commit", not squash — squashing destroys the upstream ancestry link and causes conflicts on every future merge.