Sync with main, enforce no cache modifiers on remote stores#451
Merged
mawad-amd merged 3 commits intomuhaawad/cache-modifiersfrom Mar 13, 2026
Merged
Sync with main, enforce no cache modifiers on remote stores#451mawad-amd merged 3 commits intomuhaawad/cache-modifiersfrom
mawad-amd merged 3 commits intomuhaawad/cache-modifiersfrom
Conversation
…ests Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for cache modifiers in distributed memory operations
Sync with main, enforce no cache modifiers on remote stores
Mar 13, 2026
Collaborator
|
@copilot this has conflicts with main. Rebase or resolve conflicts with main. |
…havior in docstring Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Contributor
Author
The branch has been synced with the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache modifiers are only valid for local memory operations. Remote stores (cross-GPU IPC) silently break when cache modifier bits are set. This PR syncs with
main, enforces the constraint in the API, and updates tests accordingly.API changes (
iris/iris.py)main'shintvectorization parameter into all distributed ops alongside this branch'scache_modifier/volatile/otherparamsiris.store,iris.copy,iris.put:store_cache_modifier/cache_modifieris now silently dropped for remote stores — only applied whenfrom_rank == to_rank(orto_rank == cur_rankforcopy)iris.get: unchanged — itstl.storeis always local (to_ptr)iris.load: unchanged — constraint is remote stores onlyTest updates
test_store_cache_modifiers.py: removed multi-rank loop; tests local-only stores with each cache modifiertest_put_cache_modifiers.py: changedto_rankto always equalfrom_rank(local put), sostore_cache_modifieris always exercised on a local store📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.