Skip to content

Sync with main, enforce no cache modifiers on remote stores#451

Merged
mawad-amd merged 3 commits intomuhaawad/cache-modifiersfrom
copilot/sub-pr-158-another-one
Mar 13, 2026
Merged

Sync with main, enforce no cache modifiers on remote stores#451
mawad-amd merged 3 commits intomuhaawad/cache-modifiersfrom
copilot/sub-pr-158-another-one

Conversation

Copy link
Contributor

Copilot AI commented Mar 13, 2026

Cache modifiers are only valid for local memory operations. Remote stores (cross-GPU IPC) silently break when cache modifier bits are set. This PR syncs with main, enforces the constraint in the API, and updates tests accordingly.

API changes (iris/iris.py)

  • Merged main's hint vectorization parameter into all distributed ops alongside this branch's cache_modifier/volatile/other params
  • iris.store, iris.copy, iris.put: store_cache_modifier/cache_modifier is now silently dropped for remote stores — only applied when from_rank == to_rank (or to_rank == cur_rank for copy)
  • iris.get: unchanged — its tl.store is always local (to_ptr)
  • iris.load: unchanged — constraint is remote stores only
# cache_modifier now only takes effect for local stores
iris.store(ptr, val, from_rank=0, to_rank=0, heap_bases, cache_modifier=".cs")  # applied
iris.store(ptr, val, from_rank=0, to_rank=1, heap_bases, cache_modifier=".cs")  # silently dropped

Test updates

  • test_store_cache_modifiers.py: removed multi-rank loop; tests local-only stores with each cache modifier
  • test_put_cache_modifiers.py: changed to_rank to always equal from_rank (local put), so store_cache_modifier is always exercised on a local store

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…ests

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Copilot AI changed the title [WIP] Add support for cache modifiers in distributed memory operations Sync with main, enforce no cache modifiers on remote stores Mar 13, 2026
Copilot AI requested a review from mawad-amd March 13, 2026 16:21
@mawad-amd
Copy link
Collaborator

@copilot this has conflicts with main. Rebase or resolve conflicts with main.

…havior in docstring

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 13, 2026

@copilot this has conflicts with main. Rebase or resolve conflicts with main.

The branch has been synced with the latest origin/main — commit 74f9af36. All changes from main are incorporated. The only remaining "conflict" in iris/iris.py is the intentional addition of cache_modifier, other, and volatile parameters that this PR introduces. Also clarified in the store() docstring that cache_modifier is silently ignored for remote stores (cross-GPU memory operations don't support cache modifier bits).

@mawad-amd mawad-amd marked this pull request as ready for review March 13, 2026 16:51
@mawad-amd mawad-amd requested review from BKP and neoblizz as code owners March 13, 2026 16:51
@mawad-amd mawad-amd merged commit b17b737 into muhaawad/cache-modifiers Mar 13, 2026
@mawad-amd mawad-amd deleted the copilot/sub-pr-158-another-one branch March 13, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants