fix: matmul_all_reduce lock signal must use scope="sys" for xGMI visibility#477
Draft
fix: matmul_all_reduce lock signal must use scope="sys" for xGMI visibility#477
Conversation
Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com> Agent-Logs-Url: https://github.com/ROCm/iris/sessions/09bd515d-f545-480e-b31c-040637ee3e8c
Copilot
AI
changed the title
[WIP] Fix lock writes to use scope="sys" for matmul_all_reduce
fix: matmul_all_reduce lock signal must use scope="sys" for xGMI visibility
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lock writes in
_fused_matmul_all_reduce_kernelusedscope="gpu", making them invisible to remote GPUs polling via system-scope atomics — causing intermittent hangs on multi-GPU runs.Change
iris/ops/matmul_all_reduce.py: Change lock-signal atomic fromscope="gpu"toscope="sys"The lock array lives on the symmetric heap and is mapped into all GPUs' address spaces via IPC. Any atomic on symmetric heap memory consumed by a remote rank must use
scope="sys".Original prompt
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.