forked from jax-ml/jax
-
Notifications
You must be signed in to change notification settings - Fork 13
[ROCm] Add blocking Bazel PR gate #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mminutoli
wants to merge
10
commits into
amd-main
Choose a base branch
from
rocm-blocking-pr-gate
base: amd-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dfb1a19
[ROCm] Add TheRock 7.13 and TheRock latest to CI test matrices
mminutoli d430e3b
[ROCm] Embed TheRock-aware wheel RUNPATH at link time
gulsumgudukbay b0ab890
[ROCm] Put TheRock SDK bin on PATH via so rocminfo/rocm-smi resolve …
gulsumgudukbay c0ecae1
[ROCm] Add blocking Bazel PR gate workflow
mminutoli 3ed2fa4
[ROCm] Rework blocking PR gate: file-driven targets, rocm_gate config…
mminutoli 606b991
[ROCm] Pass halt-for-connection to blocking-gate on workflow_dispatch
mminutoli 45220b1
[ROCm] Drop continue-on-error from blocking-gate (unsupported with us…
mminutoli c8503f4
[ROCm] Remove TheRock from blocking gate (ROCm 7.2.0 only)
mminutoli 99fbfce
[ROCm] Restore conditional buffer_callback_test_gpu exclusion for pre…
mminutoli 7406c5d
[ROCm] Fix bool/string type error in blocking-gate workflow inputs
mminutoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Blocking PR gate targets. | ||
| # Edit this file to tune which tests gate PRs; no workflow YAML changes needed. | ||
| # Use - prefix to exclude specific tests within a suite. | ||
| # Keep only tests that are fast and reliably passing — flaky tests block all PRs. | ||
| # Multi-GPU tests (tagged multiaccelerator) are supported: the gate runs with | ||
| # --config=multi_gpu so the RBE pool provides multi-GPU machines. | ||
|
|
||
| //tests:export_back_compat_test_gpu | ||
| //tests:sparse_test_gpu | ||
| //tests:lax_test_gpu | ||
| //tests:lax_numpy_test_gpu | ||
| //tests:pjit_test_gpu | ||
| //tests:export_harnesses_multi_platform_test_gpu | ||
| //tests:lax_autodiff_test_gpu | ||
| //tests/pallas:pallas_test_gpu | ||
| //tests:lax_numpy_operators_test_gpu | ||
| //tests:lax_control_flow_test_gpu | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| //tests:gpu_tests | ||
| //tests:backend_independent_tests | ||
| //tests/pallas:gpu_tests | ||
| //tests/pallas:backend_independent_tests | ||
| //jaxlib/tools:check_gpu_wheel_sources_test | ||
| -//tests/pallas:pallas_test_gpu | ||
| -//tests/pallas:ops_test_gpu | ||
| -//tests/pallas:ops_test_mgpu_gpu | ||
| -//tests/pallas:pallas_shape_poly_test_gpu | ||
| -//tests/pallas:pallas_vmap_test_gpu | ||
| -//tests/pallas:triton_pallas_test_gpu | ||
| -//tests:export_harnesses_multi_platform_test_gpu | ||
| -//tests:jet_test_gpu | ||
| -//tests:lax_autodiff_test_gpu | ||
| -//tests:lax_numpy_setops_test_gpu | ||
| -//tests:lax_numpy_test_gpu | ||
| -//tests:lax_test_gpu | ||
| -//tests:linalg_test_gpu | ||
| -//tests:logging_test_gpu | ||
| -//tests:random_lax_test_gpu | ||
| -//tests:scipy_signal_test_gpu | ||
| -//tests:stax_test_gpu | ||
| -//tests:ode_test_gpu | ||
| -//tests:lobpcg_test_gpu | ||
| -//tests:scipy_stats_test_gpu | ||
| -//tests:nn_test_gpu | ||
| -//tests:lax_scipy_sparse_test_gpu | ||
| -//tests:lax_scipy_spectral_dac_test_gpu | ||
| -//tests:lax_scipy_special_functions_test_gpu | ||
| -//tests:cholesky_update_test_gpu | ||
| -//tests:api_test_gpu | ||
| -//tests:ann_test_gpu | ||
| -//tests:experimental_rnn_test_gpu | ||
| -//tests:lax_vmap_test_gpu | ||
| -//tests:qdwh_test_gpu | ||
| -//tests:scaled_dot_test_gpu | ||
| -//tests:scipy_spatial_test_gpu | ||
| -//tests:shape_poly_test_gpu | ||
| -//tests:sparsify_test_gpu | ||
| -//tests:lax_numpy_reducers_test_gpu | ||
| -//tests:scipy_optimize_test_gpu | ||
| #TODO(mgaonka-amd) re-enable these tests once this issue is fixed. | ||
| -//tests:lax_numpy_einsum_test_gpu | ||
| -//tests:lax_scipy_test_gpu | ||
| -//tests:sparse_test_gpu | ||
| -//tests:sparse_bcoo_bcsr_test_gpu | ||
| -//tests:svd_test_gpu | ||
| -//tests:eigh_test_gpu | ||
| -//tests:image_test_gpu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest avoid using explicit targets in your gating CI. The reason is that these targets are getting renamed or removed. It leads to errors like target not found. It is always better to use either tag filters, skip test case internally or --test_filter argument to filter out failing tests. Consider it gives more granularity so more tests are executed.