fix(selector.js): dropdown open/close flicker on click after browser window is refocused - #6552
Open
peterjunpark wants to merge 1 commit into
Open
peterjunpark wants to merge 1 commit into
peterjunpark wants to merge 1 commit into
Conversation
…window is refocused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ISSUE ID: AIROCDOC-4124
Technical Details
When the browser window loses focus, "blur" any focused TomSelect control.
This prevents the browser from automatically restoring focus to the dropdown on window
refocus, which would trigger openOnFocus and cause the dropdown to
flicker open unexpectedly due to registering the first click as a close.
Note: "blur" just means the opposite of focus in browser lingo... not a visual blur. https://developer.mozilla.org/en-US/docs/Web/API/Window/blur_event
Test Plan
Test Result
Submission Checklist