Conversation
vstempen
requested review from
a team,
drchen-amd and
tomk-amd
as code owners
September 8, 2026 23:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is based on #1026, but it merged with roc-Optiq main. There would have been enormous amount of files to review if I pushed the change to #1026.
This change integrates profiler hub with help of profiler-hub interface library, which provides two ways communication between data-model and profiler-hub
Technical Details
The profiler hub option is currently off in CMakeLists.txt. And it will not be to compile the project with the option set to ON until we can add profiler hub as submodule or sub-tree. The latest profiler hub is not in rocm-systems main and even I tried to integrate the submodule from users/avansick-amd/optiq-reader-refactor, I wouldn't do any good because the branch has no windows support. I was able to add windows support and build all the components on my system, but I don't want to push my own version of profiler hub to roc-Optiq repository.