Revert the rocprofiler-sdk finalize warning workaround - #516
Open
magaonka-amd wants to merge 1 commit into
Open
magaonka-amd wants to merge 1 commit into
magaonka-amd wants to merge 1 commit into
Conversation
This reverts commit 431083f. ROCPROFILER_LOG_LEVEL=error was set in the TheRock base image so that the rocprofiler-sdk finalize warning stayed below the stderr threshold. Without it, that warning broke upstream JAX tests which assert a subprocess wrote nothing to stderr, e.g. tests/logging_test.py::LoggingTest::test_subprocess_toggling_logging_level. The SDK-side fix has since landed in ROCm, so the image no longer needs to override the log level. Drop the override and the associated TODO so the base image keeps the rocprofiler-sdk default logging behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #514 (commit 431083f).
What
Removes
ROCPROFILER_LOG_LEVEL=errorand its TODO comment fromdocker/Dockerfile.base-therock-ubu24. issue is fixed in rocprof-sdk and we no longer need it.