ci(clippy): deny unused code warnings#160
Merged
Conversation
Add -D unused to the CI clippy invocation so that dead code, unused imports, unused variables, and other unused-item warnings are promoted to hard errors. This prevents unused code from silently accumulating in the codebase over time through AI-assisted or manual contributions. The codebase was cleaned up in PRs ROCm#155 through ROCm#159, so the lint group passes cleanly today and this gate can now be enforced going forward.
shiv-tyagi
force-pushed
the
ci/deny-unused-warnings
branch
from
2777e32 to
9e694a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
-D unusedto the CI clippy invocation so that dead code, unused imports, unused variables, and other unused-item warnings are promoted to hard errors. This prevents unused code from silently accumulating in the codebase over time through AI written code (it tends to forget cleanup a lot).The codebase was cleaned up in PRs #155 through #159, so the lint group passes cleanly today and this gate can now be enforced going forward.