fix(registry): document asset_type matching, fix double-deactivation, add tests - #325
Merged
Merged
Conversation
… add tests - Document validate_asset_type is case- and whitespace-sensitive (RWA-ToolKit#301) - Fix deactivate_asset to skip event/write when already inactive (RWA-ToolKit#298) - Add test for get_admin before initialization panics NotInitialized (RWA-ToolKit#299) - Add tests for get_all_assets pagination edge cases (start_id=0, limit=0, past counter) (RWA-ToolKit#300) Closes RWA-ToolKit#301 Closes RWA-ToolKit#300 Closes RWA-ToolKit#299 Closes RWA-ToolKit#298
|
@MJigah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four issues in the registry contract:
validate_asset_typeis case- and whitespace-sensitive (exact byte-match required)deactivate_assetto skip event/write when asset is already inactive, preventing duplicate eventsget_adminbefore initialization (panics with NotInitialized error)get_all_assetspagination edge cases (start_id=0, limit=0, values past counter)Changes
contracts/registry/src/lib.rs
validate_asset_typeexplaining case/whitespace sensitivitydeactivate_assetto return early if asset is already inactive (before writing entry or emitting event)contracts/registry/src/test.rs
test_get_admin_before_init_panics_not_initialized(matching compliance pattern)test_get_all_assets_pagination_edge_casescovering start_id=0, limit=0, and boundary conditionstest_deactivate_already_inactive_asset_is_noopto verify idempotencyCloses #301
Closes #300
Closes #299
Closes #298