fix: review fixes from dotfiles audit#21
Merged
Conversation
- aliases: fix macOS/FreeBSD detection — `[ uname = "Darwin" ]` compared the literal string "uname" and never matched, so brew/pkg aliases never set - aliases: fix `vol` redirection order so both stdout and stderr are silenced - config.fish: drop `TERM=xterm`, which broke truecolor inside tmux - tmux: set default-terminal tmux-256color and enable truecolor passthrough - functions: confirm before `git reset --hard` in gitissue, add usage guard - install: symlink configs instead of copying so live edits flow back to repo (envvars.fish/status.conf still copied to preserve per-machine overrides); drop dead kitty mkdir - Makefile: add refresh to .PHONY - ci: bump checkout to v4, drop unused QEMU step (amd64-only on amd64 runner)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a review of the dotfiles.
Bugs
[ uname = "Darwin" ]inaliases.fishcompared the literal string"uname"to"Darwin"(it never ran the command), so theget/searchbrew/pkg aliases were never defined on those systems. Now usestest (uname) = ....volredirection backwards.2>&1 > /dev/nullsent stderr to the terminal and only stdout to the void. Now> /dev/null 2>&1.Improvements
TERM=xtermfromconfig.fish— forcing plain xterm threw away truecolor/256-color inside tmux. Instead setdefault-terminal tmux-256colorand enable truecolor passthrough intmux.conf.gitissuenow confirms beforegit reset --hard(and has a usage guard) so it can't silently discard uncommitted work.02-move-files.sh, so edits to the live config flow back to the repo.envvars.fishandstatus.confare still copied (and only if absent) to preserve per-machine overrides. Removed the deadmkdir ~/.config/kitty.refreshto.PHONY.actions/checkoutto v4 and dropped the unused QEMU setup (the matrix only buildslinux/amd64on an amd64 runner).