fix: detect default branch in gitissue instead of hardcoding master#28
Merged
Conversation
`gitissue` always checked out and pulled `master`, so it failed on any repo whose default branch is `main` (or anything else). Resolve the remote's default branch from `origin/HEAD` and use that, bailing out with a helpful message if it can't be determined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
gitissue(inconfig/fish/functions.fish) hardcodedmaster— it rangit checkout masterandgit pull origin master. On any repo whose default branch ismain(now the common default) or anything else, both commands fail and you're left on the wrong branch after agit reset --hardhas already discarded your work.Change
origin/HEAD(git symbolic-ref --short refs/remotes/origin/HEAD) and use that for the checkout/pull.origin/HEADnot set), bail out before the destructivegit reset --hardwith a hint to rungit remote set-head origin -a.Testing
fish --no-execute config/fish/functions.fishpasses (same check CI runs).🤖 Generated with Claude Code