chore: dedup Neovim plugins left over from the LSP modernization#29
Merged
Conversation
Two leftovers from the lsp-zero removal in #25: - Unify nvim-web-devicons on the nvim-tree/ repo. barbar and trouble still pulled the old kyazdani42/ name, loading the same plugin twice under two identities. - Settle on a single snippet engine. cmp expanded via vsnip while LuaSnip + friendly-snippets loaded and did nothing (friendly-snippets are LuaSnip-format, so they never reached completion). Drop vim-vsnip, expand via luasnip, lazy_load the friendly-snippets library, and add the luasnip cmp source so the snippets actually surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #25, which modernized the LSP stack but left two plugin-dedup items untouched (they were unrelated to LSP).
Changes
Unify
nvim-web-deviconsbarbarandtroublestill depended on the oldkyazdani42/nvim-web-deviconsname whilenvim-treeusednvim-tree/nvim-web-devicons— the same plugin loaded twice under two identities. All three now point atnvim-tree/.Settle on one snippet engine
cmp's
expandcalledvsnip#anonymous, but the cmp dependency block pulled inLuaSnip+cmp_luasnip+friendly-snippets. Since friendly-snippets are LuaSnip-format, they never reached completion — snippets were effectively dead. This:vim-vsnipluasnip.lsp_expandlazy_load()s the friendly-snippets libraryluasnipcmp source so snippets surface in the menuTesting
luajit -blparses the config cleanly. Not exercised by CI (headless install + syntax check only — it never opens a buffer to expand a snippet), so verify interactively: open a buffer and confirm friendly-snippets appear in completion.