fix(test): make the integration suite actually integrate - #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves the issues with the integration test suite, allowing it to run against the live Stellar Testnet without using mocked SDK elements. It also updates the CI workflow to run nightly on a schedule, fixes the setup sequence, and adds filter validations to prevent empty-match passes in the future.
Related Issue
Closes #229
Changes
🧪 Integration Tests
packages/core/jest.integration.config.jspackages/core/package.jsontest:integrationscript to target the newjest.integration.config.js.packages/core/src/__tests__/integration/balance.test.tsfundWithFriendbothelper with retry backoff and error body reporting.packages/core/src/__tests__/integration/payment.test.tsfundWithFriendbothelper for both accounts.Networks.TESTNET) before transaction submission.⚙️ CI/CD Workflows
.github/workflows/integration.ymlpnpm/action-setupruns beforeactions/setup-node.use-stellar.--fail-if-no-matchto fail loudly if no projects match.0 0 * * *) alongside manual trigger, and removedpull_requesttriggers to protect Friendbot limits.Verification Results
Local Verification
All build, lint, and typecheck commands run successfully:
pnpm lint-> Passedpnpm typecheck-> Passedpnpm build-> Passed@stellar/stellar-sdkKeypair.random()calls differbalance.test.tspasses against live testnetpayment.test.tspasses against live testnettoBeGreaterThan(0)pnpm --filtermatchesuse-stellarand fails on no-match--fail-if-no-matchpnpm/action-setupruns beforeactions/setup-nodepull_requestpnpm test(unit tests) still excludes integration and passes