fix(pagination): use limit+1 heuristic for hasNext/hasPrev - #275
Merged
Conversation
- Replace flawed \ ecords.length >= limit\ heuristic with limit+1 approach in both usePayments and useTransactionHistory. Requesting one extra record from Horizon means hasNext is true only when a further page genuinely exists, fixing the off-by-one for accounts whose total record count is an exact multiple of the page size. - Fix cursor-nulling bug: nextRef/prevRef are now set unconditionally from the Horizon response instead of being nulled when records.length === 0. Landing on an empty page no longer destroys the ability to navigate back. - Empty-page UX: when fetchNext/fetchPrev returns zero records the hook keeps the current page displayed and sets hasNext/hasPrev false, rather than replacing the list with an empty array. - Document both behaviours in JSDoc on each hook. - Add regression tests covering: exact-limit boundary (hasNext false), limit+1 boundary (hasNext true), empty-page survival (fetchPrev still callable), and hasPrev boundary case. All testnet addresses only.
|
@Trusty08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
closes #227 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227
Replace flawed
ecords.length >= limit\ heuristic with limit+1 approach in both usePayments and useTransactionHistory. Requesting one extra record from Horizon means hasNext is true only when a further page genuinely exists, fixing the off-by-one for accounts whose total record count is an exact multiple of the page size.
Fix cursor-nulling bug: nextRef/prevRef are now set unconditionally from the Horizon response instead of being nulled when records.length === 0. Landing on an empty page no longer destroys the ability to navigate back.
Empty-page UX: when fetchNext/fetchPrev returns zero records the hook keeps the current page displayed and sets hasNext/hasPrev false, rather than replacing the list with an empty array.
Document both behaviours in JSDoc on each hook.
Add regression tests covering: exact-limit boundary (hasNext false), limit+1 boundary (hasNext true), empty-page survival (fetchPrev still callable), and hasPrev boundary case. All testnet addresses only.