Conversation
Some extractables might never use caching. We do not know that since we do not know what they do in their code, but if we knew we could skip local file IO before extract. Solve this by allowing them to explicitly specify no cache support in their plugin config file using "X-Use-Cache=false" option.
Avoid returning without error being set. This caused crashes when app tried to print message of that error.
Debug message uses GST_OBJECT_NAME on a returned element pointer. In the scenario when compatible element for URI could not be found this causes crash as that macro is not safe to run on a NULL.
Makes spacing even which looks much better when an episodic series is put in playback queue.
For consistency with how elsewhere this text is displayed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability for an enhancer to specify to not use cache (e.g. when extracting local directory) - makes extraction a bit faster by skipping cache check that never exists. Also some small UX improvemens how fonts are displayed. Also a bug/crash fix was found and fixed while testing directory extraction.